Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Huang Shijie
于 2014年03月19日 21:23, y...@karo-electronics.de 写道: + /* Set up swap_block_mark, must be set before the gpmi_set_geometry() */ + if (!of_property_read_bool(this->dev->of_node, "fsl,no-blockmark-swap")) + this->swap_block_mark = !GPMI_IS_MX23(this); Our ROM guy had confi

Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Huang Shijie
于 2014年03月20日 18:09, Lothar Waßmann 写道: This can be disabled by parameter in the FCB (at least according to the i.MX6 reference Manual): from imx28's reference manual, there is not such bit in the FCB to disable the swapping. But you are disabling the swapping in the imx28's DTS file, isn't it?

Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月20日 17:21, Lothar Waßmann 写道: > > Hi, > > > > Huang Shijie wrote: > >> 于 2014年03月19日 21:23, y...@karo-electronics.de 写道: > >>> configurable via DT. This is required for the Ka-Ro electronics > >>> platforms. > >>> > >> If you disable the swapping, you will disab

Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Huang Shijie
于 2014年03月20日 17:21, Lothar Waßmann 写道: Hi, Huang Shijie wrote: 于 2014年03月19日 21:23, y...@karo-electronics.de 写道: configurable via DT. This is required for the Ka-Ro electronics platforms. If you disable the swapping, you will disable the NAND boot in actually. No. All our modules do boot

Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月19日 21:23, y...@karo-electronics.de 写道: > > configurable via DT. This is required for the Ka-Ro electronics > > platforms. > > > If you disable the swapping, you will disable the NAND boot in actually. > No. All our modules do boot from NAND and none of them do

Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Lothar Waßmann
Hi, Juergen Beisert wrote: > Hi Lothar, > > On Wednesday 19 March 2014 14:23:26 y...@karo-electronics.de wrote: > > With a flash-based BBT there is no reason to move the Factory Bad > > Block Marker from the data area buffer (to where it is mapped by the > > GPMI NAND controller) to the OOB buffe

Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Huang Shijie
于 2014年03月19日 21:23, y...@karo-electronics.de 写道: configurable via DT. This is required for the Ka-Ro electronics platforms. If you disable the swapping, you will disable the NAND boot in actually. do you need the nand boot? could you please tell me more detail background? thanks Huang Shiji

Re: [PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-20 Thread Juergen Beisert
Hi Lothar, On Wednesday 19 March 2014 14:23:26 y...@karo-electronics.de wrote: > With a flash-based BBT there is no reason to move the Factory Bad > Block Marker from the data area buffer (to where it is mapped by the > GPMI NAND controller) to the OOB buffer. Thus, make this feature > configurabl

[PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-19 Thread y
From: Lothar Waßmann With a flash-based BBT there is no reason to move the Factory Bad Block Marker from the data area buffer (to where it is mapped by the GPMI NAND controller) to the OOB buffer. Thus, make this feature configurable via DT. This is required for the Ka-Ro electronics platforms.