Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-29 Thread Robert Jarzmik
Ezequiel Garcia writes: > Robert, > > On 24 August 2015 at 15:24, Robert Jarzmik wrote: >> Ezequiel Garcia writes: >> >>> Should we worry about having two definitions for the same bit? >>> Would it be too ugly to mix the two meaning? Something like this: >>> >>> /* This bit has two different me

Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-28 Thread Ezequiel Garcia
Robert, On 24 August 2015 at 15:24, Robert Jarzmik wrote: > Ezequiel Garcia writes: > >> Should we worry about having two definitions for the same bit? >> Would it be too ugly to mix the two meaning? Something like this: >> >> /* This bit has two different meanings on NFCv1 and NFCv2 */ >> #defi

Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-24 Thread Robert Jarzmik
Ezequiel Garcia writes: > Should we worry about having two definitions for the same bit? > Would it be too ugly to mix the two meaning? Something like this: > > /* This bit has two different meanings on NFCv1 and NFCv2 */ > #define NDCR_STOP_ON_UNCOR_ARB_CNTL (0x1 << 19) I don't find that very pr

Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-24 Thread Ezequiel Garcia
On 23 Aug 09:05 PM, Robert Jarzmik wrote: > After the conversion of pxa architecture to common clock framework, the > NAND clock can be disabled on driver exit. > > In this case, it happens that if the driver used the NAND and set the > DFI arbitration bit, the next access to a static memory contr

[PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-23 Thread Robert Jarzmik
After the conversion of pxa architecture to common clock framework, the NAND clock can be disabled on driver exit. In this case, it happens that if the driver used the NAND and set the DFI arbitration bit, the next access to a static memory controller area, such as an ethernet card, will stall the