Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-05 Thread Ezequiel Garcia
On 5 September 2015 at 17:02, Robert Jarzmik wrote: > Ezequiel Garcia writes: > >> Robert, >> >> Just a couple of minor comments. >>> +dma_unmap_sg(info->dma_chan->device->dev, >>> + &info->sg, 1, info->dma_dir); >> >> Unneeded line breaking. > Indeed, for v2. > >>> +

Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-05 Thread Robert Jarzmik
Ezequiel Garcia writes: > Robert, > > Just a couple of minor comments. >> +dma_unmap_sg(info->dma_chan->device->dev, >> + &info->sg, 1, info->dma_dir); > > Unneeded line breaking. Indeed, for v2. >> +r = platform_get_resource(pdev, IORESOURCE_DMA, 1); >> +

Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-05 Thread Ezequiel Garcia
Robert, Just a couple of minor comments. On 24 Aug 08:41 PM, Robert Jarzmik wrote: > Now pxa architecture has a dmaengine driver, remove the access to direct > dma registers in favor of the more generic dmaengine code. > > This should be also applicable for mmp and orion, provided they work in >

Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-05 Thread Ezequiel Garcia
On 29 Aug 01:01 PM, Robert Jarzmik wrote: > Ezequiel Garcia writes: > > > Robert, > > > > On 24 Aug 08:41 PM, Robert Jarzmik wrote: > >> Now pxa architecture has a dmaengine driver, remove the access to direct > >> dma registers in favor of the more generic dmaengine code. > >> > >> This should

Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-08-29 Thread Robert Jarzmik
Ezequiel Garcia writes: > Robert, > > On 24 Aug 08:41 PM, Robert Jarzmik wrote: >> Now pxa architecture has a dmaengine driver, remove the access to direct >> dma registers in favor of the more generic dmaengine code. >> >> This should be also applicable for mmp and orion, provided they work in

Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-08-28 Thread Ezequiel Garcia
Robert, On 24 Aug 08:41 PM, Robert Jarzmik wrote: > Now pxa architecture has a dmaengine driver, remove the access to direct > dma registers in favor of the more generic dmaengine code. > > This should be also applicable for mmp and orion, provided they work in > device-tree environment. > > Thi

[PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-08-24 Thread Robert Jarzmik
Now pxa architecture has a dmaengine driver, remove the access to direct dma registers in favor of the more generic dmaengine code. This should be also applicable for mmp and orion, provided they work in device-tree environment. This patch also removes the previous hack which was necessary to mak