Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

On Tue, 12 Apr 2016 15:30:35 +0800 zengzhao...@163.com wrote: > From: Zhaoxiu Zeng > > If there is only one bit difference in the ECC, the function should return 1. > The result of "diff0 & ~(1< actually returns -1. > >

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

On Tue, 12 Apr 2016 15:30:35 +0800 zengzhao...@163.com wrote: > From: Zhaoxiu Zeng > > If there is only one bit difference in the ECC, the function should return 1. > The result of "diff0 & ~(1< actually returns -1. > > Signed-off-by: Zhaoxiu Zeng Applied. Thanks, Boris > --- >

[PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

From: Zhaoxiu Zeng If there is only one bit difference in the ECC, the function should return 1. The result of "diff0 & ~(1< ---

[PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

From: Zhaoxiu Zeng If there is only one bit difference in the ECC, the function should return 1. The result of "diff0 & ~(1< --- drivers/mtd/nand/s3c2410.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

Hi Zeng, On Fri, 8 Apr 2016 13:37:22 +0800 Zeng Zhaoxiu wrote: > 在 2016年04月08日 10:18, Boris Brezillon 写道: > > On Fri, 8 Apr 2016 09:51:04 +0800 > > Zeng Zhaoxiu wrote: > > > >> > >> 在 2016年04月08日 08:18, Boris Brezillon 写道: > >>> Hi Zeng, > >>> >

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

Hi Zeng, On Fri, 8 Apr 2016 13:37:22 +0800 Zeng Zhaoxiu wrote: > 在 2016年04月08日 10:18, Boris Brezillon 写道: > > On Fri, 8 Apr 2016 09:51:04 +0800 > > Zeng Zhaoxiu wrote: > > > >> > >> 在 2016年04月08日 08:18, Boris Brezillon 写道: > >>> Hi Zeng, > >>> > >>> On Fri, 8 Apr 2016 00:48:17 +0800 > >>>

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

在 2016年04月08日 10:18, Boris Brezillon 写道: On Fri, 8 Apr 2016 09:51:04 +0800 Zeng Zhaoxiu wrote: 在 2016年04月08日 08:18, Boris Brezillon 写道: Hi Zeng, On Fri, 8 Apr 2016 00:48:17 +0800 zengzhao...@163.com wrote: From: Zeng Zhaoxiu If there is

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

在 2016年04月08日 10:18, Boris Brezillon 写道: On Fri, 8 Apr 2016 09:51:04 +0800 Zeng Zhaoxiu wrote: 在 2016年04月08日 08:18, Boris Brezillon 写道: Hi Zeng, On Fri, 8 Apr 2016 00:48:17 +0800 zengzhao...@163.com wrote: From: Zeng Zhaoxiu If there is only one bit difference in the ECC, the function

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

On Fri, 8 Apr 2016 09:51:04 +0800 Zeng Zhaoxiu wrote: > > > 在 2016年04月08日 08:18, Boris Brezillon 写道: > > Hi Zeng, > > > > On Fri, 8 Apr 2016 00:48:17 +0800 > > zengzhao...@163.com wrote: > > > >> From: Zeng Zhaoxiu > >> > >> If there is only

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

On Fri, 8 Apr 2016 09:51:04 +0800 Zeng Zhaoxiu wrote: > > > 在 2016年04月08日 08:18, Boris Brezillon 写道: > > Hi Zeng, > > > > On Fri, 8 Apr 2016 00:48:17 +0800 > > zengzhao...@163.com wrote: > > > >> From: Zeng Zhaoxiu > >> > >> If there is only one bit difference in the ECC, the function should

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

在 2016年04月08日 08:18, Boris Brezillon 写道: Hi Zeng, On Fri, 8 Apr 2016 00:48:17 +0800 zengzhao...@163.com wrote: From: Zeng Zhaoxiu If there is only one bit difference in the ECC, the function should return 1. The result of "diff0 & ~(1<

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

在 2016年04月08日 08:18, Boris Brezillon 写道: Hi Zeng, On Fri, 8 Apr 2016 00:48:17 +0800 zengzhao...@163.com wrote: From: Zeng Zhaoxiu If there is only one bit difference in the ECC, the function should return 1. The result of "diff0 & ~(1< Missing Signed-off-by here. ---

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

Hi Zeng, On Fri, 8 Apr 2016 00:48:17 +0800 zengzhao...@163.com wrote: > From: Zeng Zhaoxiu > > If there is only one bit difference in the ECC, the function should return 1. > The result of "diff0 & ~(1< actually returns

Re: [PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

Hi Zeng, On Fri, 8 Apr 2016 00:48:17 +0800 zengzhao...@163.com wrote: > From: Zeng Zhaoxiu > > If there is only one bit difference in the ECC, the function should return 1. > The result of "diff0 & ~(1< actually returns -1. > > Here, we can use the simple expression "(diff0 & (diff0 - 1)) ==

[PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

From: Zeng Zhaoxiu If there is only one bit difference in the ECC, the function should return 1. The result of "diff0 & ~(1<

[PATCH] mtd: nand: s3c2410: fix bug in s3c2410_nand_correct_data()

From: Zeng Zhaoxiu If there is only one bit difference in the ECC, the function should return 1. The result of "diff0 & ~(1<