Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-20 Thread pekon
On Tuesday 19 August 2014 07:42 AM, Brian Norris wrote: On Wed, Aug 06, 2014 at 02:32:18AM +0530, pe...@pek-sem.com wrote: On Tuesday 05 August 2014 07:53 PM, Lee Jones wrote: On Thu, 03 Jul 2014, Gupta, Pekon wrote: + /* Load last page of block */ + offs = (loff_t)block << chip->p

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-18 Thread Brian Norris
On Fri, Aug 01, 2014 at 10:27:25AM +0100, Lee Jones wrote: > On Thu, 31 Jul 2014, Brian Norris wrote: > > On Thu, Jul 31, 2014 at 05:47:09PM +0100, Lee Jones wrote: > > > > > arch/arm/boot/dts/stih41x-b2020.dtsi | 40 + > > > > > > > > This will need refreshed and sent as a separat

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-18 Thread Brian Norris
On Wed, Aug 06, 2014 at 02:32:18AM +0530, pe...@pek-sem.com wrote: > On Tuesday 05 August 2014 07:53 PM, Lee Jones wrote: > >On Thu, 03 Jul 2014, Gupta, Pekon wrote: > + /* Load last page of block */ > + offs = (loff_t)block << chip->phys_erase_shift; > + offs += mtd->erasesize - mtd->w

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-06 Thread Lee Jones
On Thu, 31 Jul 2014, Lee Jones wrote: > On Wed, 02 Jul 2014, Brian Norris wrote: > > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: [...] > > > + if (IS_ERR(pdata)) > > > + return PTR_ERR(pdata); > > > + > > > + ppdata.of_node = stm_of_get_partitions_node(np, 0); > > > > So y

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-06 Thread Lee Jones
On Wed, 02 Jul 2014, Brian Norris wrote: > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: [...] > > + if (((unsigned int)buf & (NANDI_BCH_DMA_ALIGNMENT - 1)) || > > + (!virt_addr_valid(buf))) /* vmalloc'd buffer! */ > > + bounce = true; > > + > > + p = bounce ? nan

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-05 Thread pekon
Hello, On Tuesday 05 August 2014 07:53 PM, Lee Jones wrote: On Thu, 03 Jul 2014, Gupta, Pekon wrote: From: Brian Norris [mailto:computersforpe...@gmail.com] On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: [...] +static void bch_wait_seq(struct nandi_controller *nandi) +{ + in

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-05 Thread Lee Jones
On Thu, 03 Jul 2014, Gupta, Pekon wrote: > >From: Brian Norris [mailto:computersforpe...@gmail.com] > >On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: [...] > >> +/* > >> + * NANDi Interrupts (shared by Hamming and BCH controllers) > >> + */ > >> +static irqreturn_t nandi_irq_handler(i

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-08-01 Thread Lee Jones
On Thu, 31 Jul 2014, Brian Norris wrote: > On Thu, Jul 31, 2014 at 05:47:09PM +0100, Lee Jones wrote: > > Finally getting round to this ... > > Sounds like me :) :) > > On Wed, 02 Jul 2014, Brian Norris wrote: > > > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > > > > This is a squ

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-31 Thread Brian Norris
On Thu, Jul 31, 2014 at 05:47:09PM +0100, Lee Jones wrote: > Finally getting round to this ... Sounds like me :) > On Wed, 02 Jul 2014, Brian Norris wrote: > > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > > > This is a squashed version of the submission to avoid re-sending the > >

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-31 Thread Lee Jones
Finally getting round to this ... On Wed, 02 Jul 2014, Brian Norris wrote: > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > > This is a squashed version of the submission to avoid re-sending the > > entire set over and over, essentially clogging up the MLs. > > Thanks. I think I'd p

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-09 Thread Brian Norris
Hi Boris, On Tue, Jul 08, 2014 at 09:58:55AM +0200, Boris BREZILLON wrote: > On Mon, 7 Jul 2014 16:52:22 -0700 Brian Norris > wrote: > > On Thu, Jul 03, 2014 at 10:05:22AM +0200, Boris BREZILLON wrote: > > > On Wed, 2 Jul 2014 17:22:37 -0700 Brian Norris > > > wrote: > > > > > > AFAIR, the NA

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-08 Thread Boris BREZILLON
Hi Brian, On Mon, 7 Jul 2014 16:52:22 -0700 Brian Norris wrote: > Hi Boris, > > On Thu, Jul 03, 2014 at 10:05:22AM +0200, Boris BREZILLON wrote: > > On Wed, 2 Jul 2014 17:22:37 -0700 Brian Norris > > wrote: > > > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > > > > + > > > > +

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-07 Thread Brian Norris
Hi Lee, Pekon, A few additions/corrections to Pekon's comments. On Thu, Jul 03, 2014 at 09:09:27AM +, Pekon Gupta wrote: > >From: Brian Norris [mailto:computersforpe...@gmail.com] > >On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > >> diff --git a/arch/arm/boot/dts/stih41x-b2020.d

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-07 Thread Brian Norris
Hi Boris, On Thu, Jul 03, 2014 at 10:05:22AM +0200, Boris BREZILLON wrote: > On Wed, 2 Jul 2014 17:22:37 -0700 Brian Norris > wrote: > > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > > > + > > > + nand_timing0: nand-timing { > > > + sig-setup = <10>; > > > +

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-03 Thread Boris BREZILLON
Hi Brian, On Wed, 2 Jul 2014 17:22:37 -0700 Brian Norris wrote: > Hi Lee, > > On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > > This is a squashed version of the submission to avoid re-sending the > > entire set over and over, essentially clogging up the MLs. > > Thanks. I think I

Re: [PATCH] mtd: nand: stm_nand_bch: add new driver

2014-07-02 Thread Brian Norris
BTW, there are a few checkpatch.pl complaints. Please fix these for the next version (v2 or v3?) On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote: > This is a squashed version of the submission to avoid re-sending the > entire set over and over, essentially clogging up the MLs. > > Cc: c