Re: [PATCH] mtd: pxa3xx_nand: fix driver when num_cs is 0

2015-02-28 Thread Brian Norris
On Sun, Feb 08, 2015 at 09:02:09PM +0100, Robert Jarzmik wrote: > As the devicetree binding doesn't require num_cs to exist or be strictly > positive, and neither does the platform data case, a bug appear when > num_cs is set to 0 and panics the kernel. > > The issue is that in alloc_nand_resource

Re: [PATCH] mtd: pxa3xx_nand: fix driver when num_cs is 0

2015-02-14 Thread Robert Jarzmik
Ezequiel Garcia writes: > On 02/08/2015 05:02 PM, Robert Jarzmik wrote: >> As the devicetree binding doesn't require num_cs to exist or be strictly >> positive, and neither does the platform data case, a bug appear when >> num_cs is set to 0 and panics the kernel. ... >> Signed-off-by: Robert Jar

Re: [PATCH] mtd: pxa3xx_nand: fix driver when num_cs is 0

2015-02-09 Thread Ezequiel Garcia
On 02/08/2015 05:02 PM, Robert Jarzmik wrote: > As the devicetree binding doesn't require num_cs to exist or be strictly > positive, and neither does the platform data case, a bug appear when > num_cs is set to 0 and panics the kernel. > > The issue is that in alloc_nand_resource(), chip is derefe

[PATCH] mtd: pxa3xx_nand: fix driver when num_cs is 0

2015-02-08 Thread Robert Jarzmik
As the devicetree binding doesn't require num_cs to exist or be strictly positive, and neither does the platform data case, a bug appear when num_cs is set to 0 and panics the kernel. The issue is that in alloc_nand_resource(), chip is dereferenced without having a value assigned when num_cs == 0.