Re: [PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency

2019-07-05 Thread Miquel Raynal
On Sat, 2019-06-29 at 01:22:48 UTC, Paul Cercueil wrote: > If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m, > which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails: > > drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function > `ingenic_nand_remove': > ingenic_nand.c:(.text+0x177): u

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-07-01 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 9:53 PM Paul Cercueil wrote: > Le jeu. 27 juin 2019 à 18:40, Miquel Raynal > a écrit : > > Miquel Raynal wrote on Mon, 17 Jun 2019 > > 14:16:59 +0200: > >> I personally have a preference for this one. > > > > Would you mind sending the above change? I forgot about it bu

Re: [PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency

2019-07-01 Thread Paul Cercueil
Le lun. 1 juil. 2019 à 14:28, Miquel Raynal a écrit : Hi Paul, One question below. Paul Cercueil wrote on Sat, 29 Jun 2019 03:22:48 +0200: If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m, which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails: drivers/mtd/nand/raw/inge

Re: [PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency

2019-07-01 Thread Miquel Raynal
Hi Paul, One question below. Paul Cercueil wrote on Sat, 29 Jun 2019 03:22:48 +0200: > If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m, > which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails: > > drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function > `ingenic_nand_remove': >

[PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency

2019-06-28 Thread Paul Cercueil
If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m, which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails: drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function `ingenic_nand_remove': ingenic_nand.c:(.text+0x177): undefined reference to `ingenic_ecc_release' drivers/mtd/nand/raw/ingen

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-06-28 Thread Paul Cercueil
Le jeu. 27 juin 2019 à 18:40, Miquel Raynal a écrit : Hi Paul, Miquel Raynal wrote on Mon, 17 Jun 2019 14:16:59 +0200: Hello, Arnd Bergmann wrote on Mon, 17 Jun 2019 14:12:48 +0200: > On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil wrote: > > > I think there's a better way to

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-06-27 Thread Miquel Raynal
Hi Paul, Miquel Raynal wrote on Mon, 17 Jun 2019 14:16:59 +0200: > Hello, > > Arnd Bergmann wrote on Mon, 17 Jun 2019 14:12:48 +0200: > > > On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil wrote: > > > > > I think there's a better way to fix it, only in Kconfig. > > > > > > * Add a bool symb

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-06-17 Thread Miquel Raynal
Hello, Arnd Bergmann wrote on Mon, 17 Jun 2019 14:12:48 +0200: > On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil wrote: > > > I think there's a better way to fix it, only in Kconfig. > > > > * Add a bool symbol MTD_NAND_INGENIC_USE_HW_ECC > > * Have the three ECC/BCH drivers select this symbol i

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-06-17 Thread Arnd Bergmann
On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil wrote: > I think there's a better way to fix it, only in Kconfig. > > * Add a bool symbol MTD_NAND_INGENIC_USE_HW_ECC > * Have the three ECC/BCH drivers select this symbol instead of > MTD_NAND_INGENIC_ECC > * Add the following to the MTD_NAND_JZ478

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-06-17 Thread Paul Cercueil
Hi Arnd, Le lun. 17 juin 2019 à 13:10, Arnd Bergmann a écrit : The ecc code is called from the main ingenic_nand module, but the Kconfig symbol gets selected by the dependent ones. If the child drivers are loadable modules, this leads to a link error: drivers/mtd/nand/raw/ingenic/ingenic_nan

[PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-06-17 Thread Arnd Bergmann
The ecc code is called from the main ingenic_nand module, but the Kconfig symbol gets selected by the dependent ones. If the child drivers are loadable modules, this leads to a link error: drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function `ingenic_nand_remove': ingenic_nand.c:(.text+0x1a1)