Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Marek Vasut
On 05/18/2018 03:00 PM, Radu Pirea wrote: > > > On 05/18/2018 01:03 PM, Marek Vasut wrote: >> On 05/18/2018 11:50 AM, Radu Pirea wrote: >>> >>> >>> On 05/16/2018 04:47 PM, Marek Vasut wrote: On 05/16/2018 12:05 PM, Radu Pirea wrote: > On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Marek Vasut
On 05/18/2018 03:00 PM, Radu Pirea wrote: > > > On 05/18/2018 01:03 PM, Marek Vasut wrote: >> On 05/18/2018 11:50 AM, Radu Pirea wrote: >>> >>> >>> On 05/16/2018 04:47 PM, Marek Vasut wrote: On 05/16/2018 12:05 PM, Radu Pirea wrote: > On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Radu Pirea
On 05/18/2018 01:03 PM, Marek Vasut wrote: On 05/18/2018 11:50 AM, Radu Pirea wrote: On 05/16/2018 04:47 PM, Marek Vasut wrote: On 05/16/2018 12:05 PM, Radu Pirea wrote: On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: On 05/15/2018 06:22 PM, Radu Pirea wrote: On Fri, 2018-05-04 at

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Radu Pirea
On 05/18/2018 01:03 PM, Marek Vasut wrote: On 05/18/2018 11:50 AM, Radu Pirea wrote: On 05/16/2018 04:47 PM, Marek Vasut wrote: On 05/16/2018 12:05 PM, Radu Pirea wrote: On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: On 05/15/2018 06:22 PM, Radu Pirea wrote: On Fri, 2018-05-04 at

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Marek Vasut
On 05/18/2018 11:50 AM, Radu Pirea wrote: > > > On 05/16/2018 04:47 PM, Marek Vasut wrote: >> On 05/16/2018 12:05 PM, Radu Pirea wrote: >>> On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: On 05/15/2018 06:22 PM, Radu Pirea wrote: > On Fri, 2018-05-04 at 20:40 +0200, Boris

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Marek Vasut
On 05/18/2018 11:50 AM, Radu Pirea wrote: > > > On 05/16/2018 04:47 PM, Marek Vasut wrote: >> On 05/16/2018 12:05 PM, Radu Pirea wrote: >>> On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: On 05/15/2018 06:22 PM, Radu Pirea wrote: > On Fri, 2018-05-04 at 20:40 +0200, Boris

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Radu Pirea
On 05/16/2018 04:47 PM, Marek Vasut wrote: On 05/16/2018 12:05 PM, Radu Pirea wrote: On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: On 05/15/2018 06:22 PM, Radu Pirea wrote: On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: On Fri, 4 May 2018 18:54:04 +0300 Radu Pirea

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-18 Thread Radu Pirea
On 05/16/2018 04:47 PM, Marek Vasut wrote: On 05/16/2018 12:05 PM, Radu Pirea wrote: On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: On 05/15/2018 06:22 PM, Radu Pirea wrote: On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: On Fri, 4 May 2018 18:54:04 +0300 Radu Pirea

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-16 Thread Marek Vasut
On 05/16/2018 12:05 PM, Radu Pirea wrote: > On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: >> On 05/15/2018 06:22 PM, Radu Pirea wrote: >>> On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: On Fri, 4 May 2018 18:54:04 +0300 Radu Pirea wrote:

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-16 Thread Marek Vasut
On 05/16/2018 12:05 PM, Radu Pirea wrote: > On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: >> On 05/15/2018 06:22 PM, Radu Pirea wrote: >>> On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: On Fri, 4 May 2018 18:54:04 +0300 Radu Pirea wrote: > Added geometry

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-16 Thread Radu Pirea
On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: > On 05/15/2018 06:22 PM, Radu Pirea wrote: > > On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: > > > On Fri, 4 May 2018 18:54:04 +0300 > > > Radu Pirea wrote: > > > > > > > Added geometry description for

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-16 Thread Radu Pirea
On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote: > On 05/15/2018 06:22 PM, Radu Pirea wrote: > > On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: > > > On Fri, 4 May 2018 18:54:04 +0300 > > > Radu Pirea wrote: > > > > > > > Added geometry description for Microchip 25LC256 memory. >

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-15 Thread Marek Vasut
On 05/15/2018 06:22 PM, Radu Pirea wrote: > On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: >> On Fri, 4 May 2018 18:54:04 +0300 >> Radu Pirea wrote: >> >>> Added geometry description for Microchip 25LC256 memory. >> >> Same as for the dataflash stuff you

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-15 Thread Marek Vasut
On 05/15/2018 06:22 PM, Radu Pirea wrote: > On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: >> On Fri, 4 May 2018 18:54:04 +0300 >> Radu Pirea wrote: >> >>> Added geometry description for Microchip 25LC256 memory. >> >> Same as for the dataflash stuff you posted a few weeks ago: I don't

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-15 Thread Radu Pirea
On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: > On Fri, 4 May 2018 18:54:04 +0300 > Radu Pirea wrote: > > > Added geometry description for Microchip 25LC256 memory. > > Same as for the dataflash stuff you posted a few weeks ago: I don't > think this device

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-15 Thread Radu Pirea
On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: > On Fri, 4 May 2018 18:54:04 +0300 > Radu Pirea wrote: > > > Added geometry description for Microchip 25LC256 memory. > > Same as for the dataflash stuff you posted a few weeks ago: I don't > think this device belongs in the SPI NOR

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-04 Thread Boris Brezillon
On Fri, 4 May 2018 18:54:04 +0300 Radu Pirea wrote: > Added geometry description for Microchip 25LC256 memory. Same as for the dataflash stuff you posted a few weeks ago: I don't think this device belongs in the SPI NOR framework. > > Signed-off-by: Radu Pirea

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-04 Thread Boris Brezillon
On Fri, 4 May 2018 18:54:04 +0300 Radu Pirea wrote: > Added geometry description for Microchip 25LC256 memory. Same as for the dataflash stuff you posted a few weeks ago: I don't think this device belongs in the SPI NOR framework. > > Signed-off-by: Radu Pirea > --- >

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-04 Thread Marek Vasut
On 05/04/2018 05:54 PM, Radu Pirea wrote: > Added geometry description for Microchip 25LC256 memory. Are you sure this is a SPI NOR ? I don't see any RDID instruction in the datasheet, only some 6 instructions to read/write the array and lock it. Isn't the AT25 driver a better fit for this EEPROM

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-04 Thread Marek Vasut
On 05/04/2018 05:54 PM, Radu Pirea wrote: > Added geometry description for Microchip 25LC256 memory. Are you sure this is a SPI NOR ? I don't see any RDID instruction in the datasheet, only some 6 instructions to read/write the array and lock it. Isn't the AT25 driver a better fit for this EEPROM

[PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-04 Thread Radu Pirea
Added geometry description for Microchip 25LC256 memory. Signed-off-by: Radu Pirea --- drivers/mtd/devices/m25p80.c | 3 +++ drivers/mtd/spi-nor/spi-nor.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/mtd/devices/m25p80.c

[PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-04 Thread Radu Pirea
Added geometry description for Microchip 25LC256 memory. Signed-off-by: Radu Pirea --- drivers/mtd/devices/m25p80.c | 3 +++ drivers/mtd/spi-nor/spi-nor.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index