Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-07-23 Thread NeilBrown
On Mon, Jul 23 2018, Brian Norris wrote: > Hi Neil, > > On Mon, Jul 23, 2018 at 2:45 PM, NeilBrown wrote: >> On Mon, Jul 23 2018, Brian Norris wrote: >>> On Mon, Apr 9, 2018 at 6:05 PM, NeilBrown wrote: On Mon, Apr 09 2018, Marek Vasut wrote: > On 04/08/2018 11:56 PM, NeilBrown wrote: >

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-07-23 Thread Brian Norris
Hi Neil, On Mon, Jul 23, 2018 at 2:45 PM, NeilBrown wrote: > On Mon, Jul 23 2018, Brian Norris wrote: >> On Mon, Apr 9, 2018 at 6:05 PM, NeilBrown wrote: >>> On Mon, Apr 09 2018, Marek Vasut wrote: On 04/08/2018 11:56 PM, NeilBrown wrote: > were added to Linux. They appear to be design

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-07-23 Thread NeilBrown
On Mon, Jul 23 2018, Brian Norris wrote: > Hi, > > I'm a little late to this thread, but I recently noticed (and > complained about) commit: 59b356ffd0b0 ("mtd: m25p80: restore the > status of SPI flash when exiting"). > > On Mon, Apr 9, 2018 at 6:05 PM, NeilBrown wrote: >> On Mon, Apr 09 2018, M

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-07-23 Thread Brian Norris
Hi, I'm a little late to this thread, but I recently noticed (and complained about) commit: 59b356ffd0b0 ("mtd: m25p80: restore the status of SPI flash when exiting"). On Mon, Apr 9, 2018 at 6:05 PM, NeilBrown wrote: > On Mon, Apr 09 2018, Marek Vasut wrote: > >> On 04/08/2018 11:56 PM, NeilBrow

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-04-10 Thread Marek Vasut
On 04/08/2018 09:04 AM, NeilBrown wrote: > > According to section >8.2.7 Write Extended Address Register (C5h) > > of the Winbond W25Q256FV data sheet (256M-BIT SPI flash) > >The Extended Address Register is only effective when the device is >in the 3-Byte Address Mode. When the dev

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-04-10 Thread Marek Vasut
On 04/10/2018 03:05 AM, NeilBrown wrote: Skipping the previous discussion, I think there are actually two problems here. One is the reset and the other is braindead behavior of this flash. TLDR, you are right and this patch is needed (with minor tweak to make it winbond-only and possibly clean up

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-04-09 Thread NeilBrown
On Mon, Apr 09 2018, Marek Vasut wrote: > On 04/08/2018 11:56 PM, NeilBrown wrote: >> On Sun, Apr 08 2018, Marek Vasut wrote: >> >>> On 04/08/2018 09:04 AM, NeilBrown wrote: According to section 8.2.7 Write Extended Address Register (C5h) of the Winbond W25Q256FV data

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-04-09 Thread Marek Vasut
On 04/08/2018 11:56 PM, NeilBrown wrote: > On Sun, Apr 08 2018, Marek Vasut wrote: > >> On 04/08/2018 09:04 AM, NeilBrown wrote: >>> >>> According to section >>>8.2.7 Write Extended Address Register (C5h) >>> >>> of the Winbond W25Q256FV data sheet (256M-BIT SPI flash) >>> >>>The Extended

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-04-08 Thread NeilBrown
On Sun, Apr 08 2018, Marek Vasut wrote: > On 04/08/2018 09:04 AM, NeilBrown wrote: >> >> According to section >>8.2.7 Write Extended Address Register (C5h) >> >> of the Winbond W25Q256FV data sheet (256M-BIT SPI flash) >> >>The Extended Address Register is only effective when the device

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-04-08 Thread Marek Vasut
On 04/08/2018 09:04 AM, NeilBrown wrote: > > According to section >8.2.7 Write Extended Address Register (C5h) > > of the Winbond W25Q256FV data sheet (256M-BIT SPI flash) > >The Extended Address Register is only effective when the device is >in the 3-Byte Address Mode. When the dev

[PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-04-08 Thread NeilBrown
According to section 8.2.7 Write Extended Address Register (C5h) of the Winbond W25Q256FV data sheet (256M-BIT SPI flash) The Extended Address Register is only effective when the device is in the 3-Byte Address Mode. When the device operates in the 4-Byte Address Mode (ADS=1), any c