Re: [PATCH] mtd: spinand: fix error read return value

2019-06-19 Thread liaoweixiong
hi Boris Brezillon, Sure, i will adjust the commit message and send again right now. On 2019/6/20 AM12:18, Boris Brezillon wrote: > On Wed, 19 Jun 2019 14:02:14 + > Schrempf Frieder wrote: > >> On 19.06.19 15:46, Boris Brezillon wrote: >>> Hi liaoweixiong, >>> >>> On Wed, 19 Jun 2019 21:13:

Re: [PATCH] mtd: spinand: fix error read return value

2019-06-19 Thread Boris Brezillon
On Wed, 19 Jun 2019 14:02:14 + Schrempf Frieder wrote: > On 19.06.19 15:46, Boris Brezillon wrote: > > Hi liaoweixiong, > > > > On Wed, 19 Jun 2019 21:13:24 +0800 > > liaoweixiong wrote: > > > >> In function spinand_mtd_read, if the last page to read occurs bitflip, > >> this function wi

Re: [PATCH] mtd: spinand: fix error read return value

2019-06-19 Thread Schrempf Frieder
On 19.06.19 15:46, Boris Brezillon wrote: > Hi liaoweixiong, > > On Wed, 19 Jun 2019 21:13:24 +0800 > liaoweixiong wrote: > >> In function spinand_mtd_read, if the last page to read occurs bitflip, >> this function will return error value because veriable ret not equal to 0. > > Actually, that'

Re: [PATCH] mtd: spinand: fix error read return value

2019-06-19 Thread Boris Brezillon
Hi liaoweixiong, On Wed, 19 Jun 2019 21:13:24 +0800 liaoweixiong wrote: > In function spinand_mtd_read, if the last page to read occurs bitflip, > this function will return error value because veriable ret not equal to 0. Actually, that's exactly what the MTD core expects (see [1]), so you're t

[PATCH] mtd: spinand: fix error read return value

2019-06-19 Thread liaoweixiong
In function spinand_mtd_read, if the last page to read occurs bitflip, this function will return error value because veriable ret not equal to 0. Signed-off-by: liaoweixiong --- drivers/mtd/nand/spi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/spi/c