Re: [PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup()

2017-04-21 Thread Jens Axboe
On 04/21/2017 01:37 PM, Dan Carpenter wrote: > We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet. > It's weird that GCC doesn't catch this. That is weird... > diff --git a/drivers/block/mtip32xx/mtip32xx.c > b/drivers/block/mtip32xx/mtip32xx.c > index

Re: [PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup()

2017-04-21 Thread Jens Axboe
On 04/21/2017 01:37 PM, Dan Carpenter wrote: > We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet. > It's weird that GCC doesn't catch this. That is weird... > diff --git a/drivers/block/mtip32xx/mtip32xx.c > b/drivers/block/mtip32xx/mtip32xx.c > index

[PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup()

2017-04-21 Thread Dan Carpenter
We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet. It's weird that GCC doesn't catch this. Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") Signed-off-by: Dan Carpenter --- Not tested, please review carefully. diff --git

[PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup()

2017-04-21 Thread Dan Carpenter
We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet. It's weird that GCC doesn't catch this. Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") Signed-off-by: Dan Carpenter --- Not tested, please review carefully. diff --git