[PATCH] mtrr use type bool [RESEND AGAIN]

2007-11-12 Thread Paul Jimenez
This is a janitorish patch to 1) remove private TRUE/FALSE #def's in favor of using the standard enum from linux/stddef.h and 2) switch the variables holding those values to type 'bool' (from linux/types.h) since it both seems more appropriate and allows for potentially better optimization. As a

[PATCH] mtrr use type bool [RESEND]

2007-11-02 Thread Paul Jimenez
(Resending and copying the x86 maintainers since I'm not sure that Richard Gooch is still actively the mtrr maintainer. Also incorporated feedback from Richard Knutsson and Lennart Sorensen.) This is a janitorish patch to 1) remove private TRUE/FALSE #def's in favor of using the standard enum fr

Re: [PATCH] mtrr use type bool

2007-10-31 Thread Richard Knutsson
Paul Jimenez wrote: On Wednesday, Oct 31, 2007, Richard Knutsson writes: if (likely(replace < 0)) usage_table[i] = 1; else { - usage_table[i] = usage_table[replace] + !!increment; + usage_table

Re: [PATCH] mtrr use type bool

2007-10-31 Thread Richard Knutsson
Lennart Sorensen wrote: On Wed, Oct 31, 2007 at 04:27:31PM +0100, Richard Knutsson wrote: Paul Jimenez wrote: - usage_table[i] = usage_table[replace] + !!increment; + usage_table[i] = usage_table[replace] + increment; This se

Re: [PATCH] mtrr use type bool

2007-10-31 Thread Paul Jimenez
On Wednesday, Oct 31, 2007, Richard Knutsson writes: >> if (likely(replace < 0)) >> usage_table[i] = 1; >> else { >> -usage_table[i] = usage_table[replace] + !!increment; >> +usage_table[i] = usage_table[replace]

Re: [PATCH] mtrr use type bool

2007-10-31 Thread Lennart Sorensen
On Wed, Oct 31, 2007 at 04:27:31PM +0100, Richard Knutsson wrote: > Paul Jimenez wrote: > >-usage_table[i] = usage_table[replace] + !!increment; > >+usage_table[i] = usage_table[replace] + increment; > > > This seems a bit strange, using a boolean as a

Re: [PATCH] mtrr use type bool

2007-10-31 Thread Richard Knutsson
Paul Jimenez wrote: This is a janitorish patch to 1) remove private TRUE/FALSE #def's in favor of using the standard enum from linux/stddef.h and 2) switch the variables holding those values to type 'bool' (from linux/types.h) since it both seems more appropriate and allows for potentially better

[PATCH] mtrr use type bool

2007-10-30 Thread Paul Jimenez
This is a janitorish patch to 1) remove private TRUE/FALSE #def's in favor of using the standard enum from linux/stddef.h and 2) switch the variables holding those values to type 'bool' (from linux/types.h) since it both seems more appropriate and allows for potentially better optimization. As a