Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-03 Thread Andreas Kemnade
On Tue, 2 Aug 2016 23:30:16 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160802 08:14]: > > On Tue, 2 Aug 2016 03:33:34 -0700 > > Tony Lindgren wrote: > > > > > * Andreas Kemnade [160729 11:14]: > > > > The code assumes that omap2430_musb_enable() and > > > > omap2430_musb_disable() is cal

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-03 Thread Tony Lindgren
* Andreas Kemnade [160802 08:14]: > On Tue, 2 Aug 2016 03:33:34 -0700 > Tony Lindgren wrote: > > > * Andreas Kemnade [160729 11:14]: > > > The code assumes that omap2430_musb_enable() and > > > omap2430_musb_disable() is called in a balanced way. The > > > That fact is broken by the fact that m

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-02 Thread Andreas Kemnade
On Tue, 2 Aug 2016 03:33:34 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160729 11:14]: > > The code assumes that omap2430_musb_enable() and > > omap2430_musb_disable() is called in a balanced way. The > > That fact is broken by the fact that musb_init_controller() calls > > musb_platform_dis

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-02 Thread Tony Lindgren
* Andreas Kemnade [160729 11:14]: > The code assumes that omap2430_musb_enable() and > omap2430_musb_disable() is called in a balanced way. The > That fact is broken by the fact that musb_init_controller() calls > musb_platform_disable() to switch from unknown state to off state. OK, some spellin

[PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-07-29 Thread Andreas Kemnade
The code assumes that omap2430_musb_enable() and omap2430_musb_disable() is called in a balanced way. The That fact is broken by the fact that musb_init_controller() calls musb_platform_disable() to switch from unknown state to off state. That means that phy_power_off() is called first so that phy