Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-03-12 Thread Alexander Holler
Am 12.03.2013 10:04, schrieb Alexander Holler: I don't think so. Internally the driver calls mv643xx_eth_stop() therefore lockdep issues almost the same warning as when the interface is shut down (see below). And reading the code, I haven't seen how a Btw. I consider the shutdown of the interf

Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-03-12 Thread Alexander Holler
Am 12.03.2013 03:49, schrieb Lennert Buytenhek: On Fri, Mar 01, 2013 at 06:30:13PM +0100, Alexander Holler wrote: From: Lubomir Rintel = [ INFO: inconsistent lock state ] 3.7.0-6.luboskovo.fc19.armv5tel.kirkwood #1 Tainted: GW --

Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-03-11 Thread Lennert Buytenhek
On Fri, Mar 01, 2013 at 06:30:13PM +0100, Alexander Holler wrote: > >>From: Lubomir Rintel > >> > >>= > >>[ INFO: inconsistent lock state ] > >>3.7.0-6.luboskovo.fc19.armv5tel.kirkwood #1 Tainted: GW > >>- > >>inconsistent {I

Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-03-01 Thread Alexander Holler
Am 04.01.2013 21:25, schrieb Lennert Buytenhek: On Fri, Jan 04, 2013 at 03:07:02PM +0100, Lubomir Rintel wrote: From: Lubomir Rintel = [ INFO: inconsistent lock state ] 3.7.0-6.luboskovo.fc19.armv5tel.kirkwood #1 Tainted: GW

Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-01-04 Thread David Miller
From: Lubomir Rintel Date: Fri, 4 Jan 2013 15:17:43 +0100 > @@ -943,7 +943,7 @@ static int txq_reclaim(struct tx_queue *txq, int budget, > int force) > struct netdev_queue *nq = netdev_get_tx_queue(mp->dev, txq->index); > int reclaimed; > > - __netif_tx_lock(nq, smp_processor_

Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-01-04 Thread Lennert Buytenhek
On Fri, Jan 04, 2013 at 03:07:02PM +0100, Lubomir Rintel wrote: > From: Lubomir Rintel > > = > [ INFO: inconsistent lock state ] > 3.7.0-6.luboskovo.fc19.armv5tel.kirkwood #1 Tainted: GW > - > inconsistent {IN-SOFTIRQ-W} ->

[PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-01-04 Thread Lubomir Rintel
= [ INFO: inconsistent lock state ] 3.7.0-6.luboskovo.fc19.armv5tel.kirkwood #1 Tainted: GW - inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. NetworkManager/337 [HC0[0]:SC0[0]:HE1:SE1] takes: (_xmit_ETHER#2){+.?...}, at:

[PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

2013-01-04 Thread Lubomir Rintel
From: Lubomir Rintel = [ INFO: inconsistent lock state ] 3.7.0-6.luboskovo.fc19.armv5tel.kirkwood #1 Tainted: GW - inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. NetworkManager/337 [HC0[0]:SC0[0]:HE1:SE1] takes: (_xmit