Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Javier Martinez Canillas
Hello Arend, On 08/18/2016 03:49 PM, Arend van Spriel wrote: > > > On 18-08-16 21:29, Javier Martinez Canillas wrote: >> Hello Arend, >> >> Thanks a lot for your feedback. >> >> On 08/18/2016 03:14 PM, Arend van Spriel wrote: >>> On 18-08-16 16:17, Javier Martinez Canillas wrote: If request

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Javier Martinez Canillas
Hello Arend, Thanks a lot for your feedback. On 08/18/2016 03:14 PM, Arend van Spriel wrote: > On 18-08-16 16:17, Javier Martinez Canillas wrote: >> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >> is printed but the actual error is not propagated to the caller function

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Arend van Spriel
On 18-08-16 16:17, Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. Hmm. The caller function, ie. mwifiex_sdio_probe(), does not seem to care. The device may still

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Arend van Spriel
On 18-08-16 21:29, Javier Martinez Canillas wrote: > Hello Arend, > > Thanks a lot for your feedback. > > On 08/18/2016 03:14 PM, Arend van Spriel wrote: >> On 18-08-16 16:17, Javier Martinez Canillas wrote: >>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >>> is pri

[PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Javier Martinez Canillas
If request_irq() fails in mwifiex_sdio_probe_of(), only an error message is printed but the actual error is not propagated to the caller function. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/