Re: [PATCH] namei: Remove unlikely annotation for revalidate check in lookup_fast()

2017-02-06 Thread Steven Rostedt
On Tue, 7 Feb 2017 00:06:42 + Al Viro wrote: > On Mon, Feb 06, 2017 at 05:17:35PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > The likely/unlikely profiler showed that the unlikely around the > > dentry->d_flags & DCACHE_OP_REVALIDATE was wrong 95% of the time. A

Re: [PATCH] namei: Remove unlikely annotation for revalidate check in lookup_fast()

2017-02-06 Thread Al Viro
On Mon, Feb 06, 2017 at 05:17:35PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The likely/unlikely profiler showed that the unlikely around the > dentry->d_flags & DCACHE_OP_REVALIDATE was wrong 95% of the time. Adding > trace_printk()s, it revealed that the dentry ops had

[PATCH] namei: Remove unlikely annotation for revalidate check in lookup_fast()

2017-02-06 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The likely/unlikely profiler showed that the unlikely around the dentry->d_flags & DCACHE_OP_REVALIDATE was wrong 95% of the time. Adding trace_printk()s, it revealed that the dentry ops had hooks to: kernfs_dop_revalidate pid_revalidate proc_sys_revalidate ti