Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-29 Thread Serge E. Hallyn
Quoting Herbert Poetzl ([EMAIL PROTECTED]): > On Thu, Jan 25, 2007 at 10:30:56PM -0800, Andrew Morton wrote: > > On Thu, 25 Jan 2007 23:26:59 -0600 > > "Serge E. Hallyn" <[EMAIL PROTECTED]> wrote: > > > > > Fix exit race by splitting the nsproxy putting into two pieces. > > > First piece reduces

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-29 Thread Herbert Poetzl
On Thu, Jan 25, 2007 at 10:30:56PM -0800, Andrew Morton wrote: > On Thu, 25 Jan 2007 23:26:59 -0600 > "Serge E. Hallyn" <[EMAIL PROTECTED]> wrote: > > > Fix exit race by splitting the nsproxy putting into two pieces. > > First piece reduces the nsproxy refcount. If we dropped the last > >

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-29 Thread Herbert Poetzl
On Thu, Jan 25, 2007 at 10:30:56PM -0800, Andrew Morton wrote: On Thu, 25 Jan 2007 23:26:59 -0600 Serge E. Hallyn [EMAIL PROTECTED] wrote: Fix exit race by splitting the nsproxy putting into two pieces. First piece reduces the nsproxy refcount. If we dropped the last reference, then it

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-29 Thread Serge E. Hallyn
Quoting Herbert Poetzl ([EMAIL PROTECTED]): On Thu, Jan 25, 2007 at 10:30:56PM -0800, Andrew Morton wrote: On Thu, 25 Jan 2007 23:26:59 -0600 Serge E. Hallyn [EMAIL PROTECTED] wrote: Fix exit race by splitting the nsproxy putting into two pieces. First piece reduces the nsproxy

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-26 Thread Oleg Nesterov
On 01/26, Daniel Hokka Zakrisson wrote: > > Serge E. Hallyn wrote: > > Ok, could you verify that the following patch at least solves > > the oopsing? > > > > (I can't reproduce the oops with Daniel's test prog) > > > > thanks, > > -serge > > Indeed, this patch solves the oopsing, but so did the

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-26 Thread Daniel Hokka Zakrisson
Serge E. Hallyn wrote: > Ok, could you verify that the following patch at least solves > the oopsing? > > (I can't reproduce the oops with Daniel's test prog) > > thanks, > -serge Indeed, this patch solves the oopsing, but so did the last one. I think I finally managed to figure out why too, as

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-26 Thread Daniel Hokka Zakrisson
Serge E. Hallyn wrote: Ok, could you verify that the following patch at least solves the oopsing? (I can't reproduce the oops with Daniel's test prog) thanks, -serge Indeed, this patch solves the oopsing, but so did the last one. I think I finally managed to figure out why too, as

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-26 Thread Oleg Nesterov
On 01/26, Daniel Hokka Zakrisson wrote: Serge E. Hallyn wrote: Ok, could you verify that the following patch at least solves the oopsing? (I can't reproduce the oops with Daniel's test prog) thanks, -serge Indeed, this patch solves the oopsing, but so did the last one. I think I

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-25 Thread Andrew Morton
On Thu, 25 Jan 2007 23:26:59 -0600 "Serge E. Hallyn" <[EMAIL PROTECTED]> wrote: > Fix exit race by splitting the nsproxy putting into two pieces. > First piece reduces the nsproxy refcount. This broke introduce-and-use-get_task_mnt_ns.patch

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-25 Thread Andrew Morton
On Thu, 25 Jan 2007 23:26:59 -0600 "Serge E. Hallyn" <[EMAIL PROTECTED]> wrote: > Fix exit race by splitting the nsproxy putting into two pieces. > First piece reduces the nsproxy refcount. If we dropped the last > reference, then it puts the mnt_ns, and returns the nsproxy as a > hint to the

[PATCH] namespaces: fix exit race by splitting exit

2007-01-25 Thread Serge E. Hallyn
Ok, could you verify that the following patch at least solves the oopsing? (I can't reproduce the oops with Daniel's test prog) thanks, -serge From: Serge E. Hallyn <[EMAIL PROTECTED]> Subject: [PATCH] namespaces: fix exit race by splitting exit Fix exit race by splitting the nsproxy p

[PATCH] namespaces: fix exit race by splitting exit

2007-01-25 Thread Serge E. Hallyn
Ok, could you verify that the following patch at least solves the oopsing? (I can't reproduce the oops with Daniel's test prog) thanks, -serge From: Serge E. Hallyn [EMAIL PROTECTED] Subject: [PATCH] namespaces: fix exit race by splitting exit Fix exit race by splitting the nsproxy putting

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-25 Thread Andrew Morton
On Thu, 25 Jan 2007 23:26:59 -0600 Serge E. Hallyn [EMAIL PROTECTED] wrote: Fix exit race by splitting the nsproxy putting into two pieces. First piece reduces the nsproxy refcount. If we dropped the last reference, then it puts the mnt_ns, and returns the nsproxy as a hint to the caller.

Re: [PATCH] namespaces: fix exit race by splitting exit

2007-01-25 Thread Andrew Morton
On Thu, 25 Jan 2007 23:26:59 -0600 Serge E. Hallyn [EMAIL PROTECTED] wrote: Fix exit race by splitting the nsproxy putting into two pieces. First piece reduces the nsproxy refcount. This broke introduce-and-use-get_task_mnt_ns.patch