Re: [PATCH] nbd: add missed destroy_workqueue when nbd_start_device fails

2020-07-25 Thread Michael Christie
> On Jul 24, 2020, at 9:27 PM, Li Heng wrote: > > destroy_workqueue() should be called to destroy ndev->tx_wq > when nbd_start_device init resources fails. > > Reported-by: Hulk Robot > Signed-off-by: Li Heng > --- > drivers/block/nbd.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH] nbd: add missed destroy_workqueue when nbd_start_device fails

2020-07-25 Thread Markus Elfring
> destroy_workqueue() should be called to destroy ndev->tx_wq > when nbd_start_device init resources fails. * An imperative wording can be preferred for the change description, can't it? * Would you like to add the tag “Fixes” to the commit message? Regards, Markus

[PATCH] nbd: add missed destroy_workqueue when nbd_start_device fails

2020-07-24 Thread Li Heng
destroy_workqueue() should be called to destroy ndev->tx_wq when nbd_start_device init resources fails. Reported-by: Hulk Robot Signed-off-by: Li Heng --- drivers/block/nbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index