Re: [PATCH] net/dns_resolver: dns_query Modify parameter checking to avoid dead code

2018-06-04 Thread Simon Horman
On Mon, Jun 04, 2018 at 02:40:31PM +0800, nixiaoming wrote: > After commit 1a4240f4764a ("DNS: Separate out CIFS DNS Resolver code") > a dead code exists in function dns_query > > code show as below: > if (!name || namelen == 0) > return -EINVAL; > /*Now the value of "nam

[PATCH] net/dns_resolver: dns_query Modify parameter checking to avoid dead code

2018-06-04 Thread nixiaoming
After commit 1a4240f4764a ("DNS: Separate out CIFS DNS Resolver code") a dead code exists in function dns_query code show as below: if (!name || namelen == 0) return -EINVAL; /*Now the value of "namelen" cannot be equal to 0*/ if (!namelen) /*Th