Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-27 Thread Tim Hansen
> Tue, Sep 26, 2017 at 08:03:39PM -0700, David Miller wrote: > From: Tim Hansen > Date: Tue, 26 Sep 2017 20:54:05 -0400 > > > Signed-off-by: Tim Hansen > > This is a poor patch submission on many levels. > Apologies Dave, this is my first patch. I

Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-27 Thread Tim Hansen
> Tue, Sep 26, 2017 at 08:03:39PM -0700, David Miller wrote: > From: Tim Hansen > Date: Tue, 26 Sep 2017 20:54:05 -0400 > > > Signed-off-by: Tim Hansen > > This is a poor patch submission on many levels. > Apologies Dave, this is my first patch. I appreciate the quick review and helpful

Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-26 Thread David Miller
From: Tim Hansen Date: Tue, 26 Sep 2017 20:54:05 -0400 > Signed-off-by: Tim Hansen This is a poor patch submission on many levels. But the main problem, is that there is no use of sk_for_each_entry_offset_rcu() in any of my networking kernel

Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-26 Thread David Miller
From: Tim Hansen Date: Tue, 26 Sep 2017 20:54:05 -0400 > Signed-off-by: Tim Hansen This is a poor patch submission on many levels. But the main problem, is that there is no use of sk_for_each_entry_offset_rcu() in any of my networking kernel trees. Referencing code by line number never

[PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-26 Thread Tim Hansen
Signed-off-by: Tim Hansen --- include/net/sock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index aeeec62992ca..516289f6404b 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -732,10 +732,10 @@

[PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-26 Thread Tim Hansen
Signed-off-by: Tim Hansen --- include/net/sock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index aeeec62992ca..516289f6404b 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -732,10 +732,10 @@ static inline void