Re: [PATCH] net/lib80211: scrubbing the buffer for key

2019-10-18 Thread Johannes Berg
On Thu, 2019-10-17 at 23:53 -0500, Kangjie Lu wrote: > The "key" is not scrubbed. As what peer modules do, the fixes zeros > out the key buffer. Why do you think this is useful/necessary? Please always describe that in the commit log. FWIW, I'm convinced that it's not at necessary at all, looking

[PATCH] net/lib80211: scrubbing the buffer for key

2019-10-17 Thread Kangjie Lu
The "key" is not scrubbed. As what peer modules do, the fixes zeros out the key buffer. Signed-off-by: Kangjie Lu --- net/wireless/lib80211_crypt_wep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless/lib80211_crypt_wep.c b/net/wireless/lib80211_crypt_wep.c index dafc6f3571db..0