Re: [PATCH] net/tcp: track all ipv4/tcp state transition in tcp_set_state

2017-11-08 Thread Yafang Shao
2017-11-08 14:51 GMT+08:00 David Miller : > From: Yafang Shao > Date: Tue, 7 Nov 2017 18:36:28 +0800 > >> When I hooked the function tcp_set_state with kprobe to track the ipv4/tcp >> state transistion, I found state transition from TCP_LISTEN to TCP_SYN_RECV >> is missed. >> >> I think it is bet

Re: [PATCH] net/tcp: track all ipv4/tcp state transition in tcp_set_state

2017-11-07 Thread David Miller
From: Yafang Shao Date: Tue, 7 Nov 2017 18:36:28 +0800 > When I hooked the function tcp_set_state with kprobe to track the ipv4/tcp > state transistion, I found state transition from TCP_LISTEN to TCP_SYN_RECV > is missed. > > I think it is better to use the helper to do state transition instea

[PATCH] net/tcp: track all ipv4/tcp state transition in tcp_set_state

2017-11-07 Thread Yafang Shao
When I hooked the function tcp_set_state with kprobe to track the ipv4/tcp state transistion, I found state transition from TCP_LISTEN to TCP_SYN_RECV is missed. I think it is better to use the helper to do state transition instead of assigning the state to sk_state directly. Then we can monitor t