Re: [PATCH] net: Remove the source address setting in connect() for UDP

2019-09-11 Thread David Miller
From: "Enke Chen (enkechen)" Date: Tue, 10 Sep 2019 23:55:59 + > Do you still have concerns about backward compatibility of the fix? I'm not convinced by your arguments and I am also completely swamped at LPC2019 running the networking track this week.

Re: [PATCH] net: Remove the source address setting in connect() for UDP

2019-09-10 Thread Enke Chen (enkechen)
9 at 12:23 AM To: David Miller Cc: "kuz...@ms2.inr.ac.ru" , "yoshf...@linux-ipv6.org" , "net...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "xe-linux-external(mailer list)" , "Enke Chen (enkechen)" Subject: Re: [PATCH] net: Remo

Re: [PATCH] net: Remove the source address setting in connect() for UDP

2019-09-06 Thread Enke Chen (enkechen)
s2.inr.ac.ru" , "yoshf...@linux-ipv6.org" , "net...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "xe-linux-external(mailer list)" Subject: Re: [PATCH] net: Remove the source address setting in connect() for UDP From: Enke Chen Date: Thu, 5 Sep

Re: [PATCH] net: Remove the source address setting in connect() for UDP

2019-09-06 Thread David Miller
From: Enke Chen Date: Thu, 5 Sep 2019 19:54:37 -0700 > The connect() system call for a UDP socket is for setting the destination > address and port. But the current code mistakenly sets the source address > for the socket as well. Remove the source address setting in connect() for > UDP in this

[PATCH] net: Remove the source address setting in connect() for UDP

2019-09-05 Thread Enke Chen
The connect() system call for a UDP socket is for setting the destination address and port. But the current code mistakenly sets the source address for the socket as well. Remove the source address setting in connect() for UDP in this patch. Implications of the bug: - Packet drop: On a mul