Re: [PATCH] net: dsa/mv88e6352: make mv88e6352_wait generic

2015-01-27 Thread David Miller
From: Vivien Didelot Date: Fri, 23 Jan 2015 18:34:41 -0500 > Some busy bits are available in the global register 1, such as the ATU > Busy bit. We may want to use this function to wait for them to change, > so add a new parameter to mv88e6352_wait() instead of hard-coding > REG_GLOBAL2. > > In t

Re: [PATCH] net: dsa/mv88e6352: make mv88e6352_wait generic

2015-01-23 Thread Guenter Roeck
On 01/23/2015 03:34 PM, Vivien Didelot wrote: Some busy bits are available in the global register 1, such as the ATU Busy bit. We may want to use this function to wait for them to change, so add a new parameter to mv88e6352_wait() instead of hard-coding REG_GLOBAL2. In the meantime, since the RE

[PATCH] net: dsa/mv88e6352: make mv88e6352_wait generic

2015-01-23 Thread Vivien Didelot
Some busy bits are available in the global register 1, such as the ATU Busy bit. We may want to use this function to wait for them to change, so add a new parameter to mv88e6352_wait() instead of hard-coding REG_GLOBAL2. In the meantime, since the REG_READ() macro already checks for error, remove