Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-06-02 Thread David Miller
From: Nikita Yushchenko Date: Fri, 31 May 2019 10:35:14 +0300 > When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error > message is logged: > > failed to kill vid 0081/0 for device eth_cu_1000_4 > > This is caused by call from __vlan_vid_del() with vin set to zero, over > call chain

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Vivien Didelot
On Fri, 31 May 2019 10:35:14 +0300, Nikita Yushchenko wrote: > When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error > message is logged: > > failed to kill vid 0081/0 for device eth_cu_1000_4 > > This is caused by call from __vlan_vid_del() with vin set to zero, over > call chain

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Vivien Didelot
Hi Florian, On Fri, 31 May 2019 09:34:03 -0700, Florian Fainelli wrote: > On 5/31/19 7:37 AM, Andrew Lunn wrote: > >> I'm not sure that I like the semantic of it, because the driver can > >> actually > >> support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would > >> avoid > >> c

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Florian Fainelli
On 5/31/19 11:19 AM, Vivien Didelot wrote: > Hi Florian, > > On Fri, 31 May 2019 09:36:13 -0700, Florian Fainelli > wrote: >>> But VID 0 has a special meaning for the kernel, it means the port's private >>> database (when it is isolated, non-bridged), it is not meant to be >>> programmed >>> in

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Vivien Didelot
Hi Florian, On Fri, 31 May 2019 09:36:13 -0700, Florian Fainelli wrote: > > But VID 0 has a special meaning for the kernel, it means the port's private > > database (when it is isolated, non-bridged), it is not meant to be > > programmed > > in the switch. That's why I would've put that knowled

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Florian Fainelli
On 5/31/19 7:31 AM, Vivien Didelot wrote: > Hi Nikita, > > On Fri, 31 May 2019 10:35:14 +0300, Nikita Yushchenko > wrote: >> When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error >> message is logged: >> >> failed to kill vid 0081/0 for device eth_cu_1000_4 >> >> This is caused by c

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Florian Fainelli
On 5/31/19 8:00 AM, Vivien Didelot wrote: > Hi Nikita, > > On Fri, 31 May 2019 17:46:29 +0300, Nikita Yushchenko > wrote: >> >> >> 31.05.2019 17:37, Andrew Lunn wrote: I'm not sure that I like the semantic of it, because the driver can actually support VID 0 per-se, only the kern

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Florian Fainelli
On 5/31/19 7:37 AM, Andrew Lunn wrote: >> I'm not sure that I like the semantic of it, because the driver can actually >> support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would avoid >> calling the port_vlan_del() ops for VID 0, directly into the upper DSA layer. >> >> Florian, And

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Nikita Yushchenko
>> Kernel currently does, but it is caught in >> mv88e6xxx_port_check_hw_vlan() and returns -ENOTSUPP from there. > > But VID 0 has a special meaning for the kernel, it means the port's private > database (when it is isolated, non-bridged), it is not meant to be programmed > in the switch. That's

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Vivien Didelot
Hi Nikita, On Fri, 31 May 2019 17:46:29 +0300, Nikita Yushchenko wrote: > > > 31.05.2019 17:37, Andrew Lunn wrote: > >> I'm not sure that I like the semantic of it, because the driver can > >> actually > >> support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would > >> avoid >

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Nikita Yushchenko
31.05.2019 17:37, Andrew Lunn wrote: >> I'm not sure that I like the semantic of it, because the driver can actually >> support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would avoid >> calling the port_vlan_del() ops for VID 0, directly into the upper DSA layer. >> >> Florian, An

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Andrew Lunn
> I'm not sure that I like the semantic of it, because the driver can actually > support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would avoid > calling the port_vlan_del() ops for VID 0, directly into the upper DSA layer. > > Florian, Andrew, wouldn't the following patch be more a

Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Vivien Didelot
Hi Nikita, On Fri, 31 May 2019 10:35:14 +0300, Nikita Yushchenko wrote: > When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error > message is logged: > > failed to kill vid 0081/0 for device eth_cu_1000_4 > > This is caused by call from __vlan_vid_del() with vin set to zero, over >

[PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Nikita Yushchenko
When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error message is logged: failed to kill vid 0081/0 for device eth_cu_1000_4 This is caused by call from __vlan_vid_del() with vin set to zero, over call chain this results into _mv88e6xxx_port_vlan_del() called with vid=0, and mv88e6xxx

[PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

2019-05-31 Thread Nikita Yushchenko
When non-bridged, non-vlan'ed mv88e6xxx port is moving down, error message is logged: failed to kill vid 0081/0 for device eth_cu_1000_4 This is caused by call from __vlan_vid_del() with vin set to zero, over call chain this results into _mv88e6xxx_port_vlan_del() called with vid=0, and mv88e6xxx