Re: [PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register()

On Thu Nov 12 2020, YueHaibing wrote: > drivers/net/dsa/sja1105/sja1105_ptp.c:869 sja1105_ptp_clock_register() warn: > passing zero to 'PTR_ERR' > > ptp_clock_register() returns ERR_PTR() and never returns > NULL. The NULL test should be removed. Which is not true. From the documentation: *

[PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register()

drivers/net/dsa/sja1105/sja1105_ptp.c:869 sja1105_ptp_clock_register() warn: passing zero to 'PTR_ERR' ptp_clock_register() returns ERR_PTR() and never returns NULL. The NULL test should be removed. Fixes: bb77f36ac21d ("net: dsa: sja1105: Add support for the PTP clock") Signed-off-by: