Re: [PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe

2017-12-07 Thread David Miller
From: Branislav Radocaj Date: Thu, 7 Dec 2017 00:07:38 +0100 > If clk_set_rate() fails, we should disable clk before return. > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Branislav Radocaj Ok, but this probe routine is very inconsistent in how it handles

[PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe

2017-12-06 Thread Branislav Radocaj
If clk_set_rate() fails, we should disable clk before return. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Branislav Radocaj --- drivers/net/ethernet/arc/emac_rockchip.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethern

Re: [PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe

2017-12-06 Thread David Miller
From: Branislav Radocaj Date: Wed, 6 Dec 2017 18:24:33 +0100 > If clk_set_rate() fails, we should disable clk > before return. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Branislav Radocaj Please eliminate this indentation of your com

[PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe

2017-12-06 Thread Branislav Radocaj
If clk_set_rate() fails, we should disable clk before return. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Branislav Radocaj --- drivers/net/ethernet/arc/emac_rockchip.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/d