Re: [PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-18 Thread Andrew Lunn
On Fri, Jul 17, 2020 at 04:21:51PM +0100, Mark Einon wrote: > On Fri, 2020-07-17 at 15:40 +0200, Andrew Lunn wrote: > > On Fri, Jul 17, 2020 at 02:21:35PM +0100, Mark Einon wrote: > > > Following the removal of an unused variable assignment (remove > > > unused variable 'pm_csr') the associated

Re: [PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-17 Thread David Miller
From: Mark Einon Date: Fri, 17 Jul 2020 14:21:35 +0100 > Following the removal of an unused variable assignment (remove > unused variable 'pm_csr') the associated register read can also go, > as the read also occurs in the subsequent et1310_in_phy_coma() > call. > > Signed-off-by: Mark Einon

Re: [PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-17 Thread Mark Einon
On Fri, 2020-07-17 at 15:40 +0200, Andrew Lunn wrote: > On Fri, Jul 17, 2020 at 02:21:35PM +0100, Mark Einon wrote: > > Following the removal of an unused variable assignment (remove > > unused variable 'pm_csr') the associated register read can also go, > > as the read also occurs in the

Re: [PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-17 Thread Andrew Lunn
On Fri, Jul 17, 2020 at 02:21:35PM +0100, Mark Einon wrote: > Following the removal of an unused variable assignment (remove > unused variable 'pm_csr') the associated register read can also go, > as the read also occurs in the subsequent et1310_in_phy_coma() > call. Hi Mark Do you have any

[PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-17 Thread Mark Einon
Following the removal of an unused variable assignment (remove unused variable 'pm_csr') the associated register read can also go, as the read also occurs in the subsequent et1310_in_phy_coma() call. Signed-off-by: Mark Einon --- drivers/net/ethernet/agere/et131x.c | 3 --- 1 file changed, 3