Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-28 Thread Fabio Estevam
Hi Laurent, On Mon, May 13, 2013 at 4:37 PM, Laurent Navet wrote: > Replace a call to deprecated devm_request_and_ioremap by > devm_ioremap_resource. > also remove tests on 'r' since devm_ioremap_resource() checks for it > in a better way. > > Found with coccicheck and this semantic patch: >

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-28 Thread Fabio Estevam
Hi Laurent, On Mon, May 13, 2013 at 4:37 PM, Laurent Navet laurent.na...@gmail.com wrote: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'r' since devm_ioremap_resource() checks for it in a better way. Found with coccicheck and this

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Frank Li
2013/5/14 Laurent Navet : > struct resource *res) > { > ... > if (!res || resource_type(res) != IORESOURCE_MEM) { > dev_err(dev, "invalid resource\n"); > return ERR_PTR(-EINVAL); Okay, thanks. Acked -- To unsubscribe from this list: send the line

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
>> --- a/drivers/net/ethernet/freescale/fec_main.c >> +++ b/drivers/net/ethernet/freescale/fec_main.c >> @@ -1843,8 +1843,6 @@ fec_probe(struct platform_device *pdev) >> pdev->id_entry = of_id->data; >> >> r = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Frank Li
2013/5/14 Laurent Navet : > Replace a call to deprecated devm_request_and_ioremap by > devm_ioremap_resource. > also remove tests on 'r' since devm_ioremap_resource() checks for it > in a better way. > > Found with coccicheck and this semantic patch: >

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Frank Li
2013/5/14 Laurent Navet laurent.na...@gmail.com: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'r' since devm_ioremap_resource() checks for it in a better way. Found with coccicheck and this semantic patch:

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
--- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1843,8 +1843,6 @@ fec_probe(struct platform_device *pdev) pdev-id_entry = of_id-data; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) -

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Frank Li
2013/5/14 Laurent Navet laurent.na...@gmail.com: struct resource *res) { ... if (!res || resource_type(res) != IORESOURCE_MEM) { dev_err(dev, invalid resource\n); return ERR_PTR(-EINVAL); Okay, thanks. Acked -- To unsubscribe from this list: send

[PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'r' since devm_ioremap_resource() checks for it in a better way. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet

[PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'r' since devm_ioremap_resource() checks for it in a better way. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet