RE: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Duan Andy
Stefan Agner > Subject: Re: [PATCH] net: fec: fix enet_out clock handling > > Hi, > > > From: Lothar Waßmann Sent: Friday, November > > 27, 2015 9:39 PM > > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Kevin Hao; > > > Lothar Waßmann; Lucas Stach; D

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Lothar Waßmann
nel@vger.kernel.org; net...@vger.kernel.org; > > Stefan Agner > > Subject: [PATCH] net: fec: fix enet_out clock handling > > > > When ENET_OUT is being used as reference clock for an external PHY, the > > clock must not be disabled while the PHY is active. Otherwise the PHY may >

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Lothar Waßmann
Hi, > On Fri, Nov 27, 2015 at 02:39:10PM +0100, Lothar Waßmann wrote: > > When ENET_OUT is being used as reference clock for an external PHY, > > the clock must not be disabled while the PHY is active. Otherwise the > > PHY may lose its internal state and require a reset to become > > functional

RE: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Duan Andy
Stefan Agner > Subject: Re: [PATCH] net: fec: fix enet_out clock handling > > > When MAC is not ready with clocks disabled, it is not necessary to > > supply clock for PHY. In fact, PHY also is not ready, why does it need > > clock ? > > How about the case of the "PHY&qu

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Andrew Lunn
On Fri, Nov 27, 2015 at 02:39:10PM +0100, Lothar Waßmann wrote: > When ENET_OUT is being used as reference clock for an external PHY, > the clock must not be disabled while the PHY is active. Otherwise the > PHY may lose its internal state and require a reset to become > functional again. > > A

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Andrew Lunn
> Do you mean PHY switch also use the enet_out clock ? Yes, the Marvell switches i've have connected to a Vybrid use enet_out clock. There was a recent change to IMX pinctrl which broke the muxing for ENET_OUT on Vydrid, which broke the probing of these switches. It was no longer possible to mux

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Andrew Lunn
> Do you mean PHY switch also use the enet_out clock ? Yes, the Marvell switches i've have connected to a Vybrid use enet_out clock. There was a recent change to IMX pinctrl which broke the muxing for ENET_OUT on Vydrid, which broke the probing of these switches. It was no longer possible to mux

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Andrew Lunn
On Fri, Nov 27, 2015 at 02:39:10PM +0100, Lothar Waßmann wrote: > When ENET_OUT is being used as reference clock for an external PHY, > the clock must not be disabled while the PHY is active. Otherwise the > PHY may lose its internal state and require a reset to become > functional again. > > A

RE: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Duan Andy
..@vger.kernel.org; Stefan Agner > Subject: Re: [PATCH] net: fec: fix enet_out clock handling > > > When MAC is not ready with clocks disabled, it is not necessary to > > supply clock for PHY. In fact, PHY also is not ready, why does it need > > clock ? > > How about the

RE: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Duan Andy
er.kernel.org; net...@vger.kernel.org; Stefan Agner > Subject: Re: [PATCH] net: fec: fix enet_out clock handling > > Hi, > > > From: Lothar Waßmann <l...@karo-electronics.de> Sent: Friday, November > > 27, 2015 9:39 PM > > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Lothar Waßmann
Uwe Kleine-König; linux-kernel@vger.kernel.org; net...@vger.kernel.org; > > Stefan Agner > > Subject: [PATCH] net: fec: fix enet_out clock handling > > > > When ENET_OUT is being used as reference clock for an external PHY, the > > clock must not be disabled while the PHY

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Lothar Waßmann
Hi, > On Fri, Nov 27, 2015 at 02:39:10PM +0100, Lothar Waßmann wrote: > > When ENET_OUT is being used as reference clock for an external PHY, > > the clock must not be disabled while the PHY is active. Otherwise the > > PHY may lose its internal state and require a reset to become > > functional

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-28 Thread Andrew Lunn
> When MAC is not ready with clocks disabled, it is not necessary to > supply clock for PHY. In fact, PHY also is not ready, why does it > need clock ? How about the case of the "PHY" is actually a switch? You can use the MDIO bus separate from the MAC, you can configure the switch while the MAC

RE: [PATCH] net: fec: fix enet_out clock handling

2015-11-28 Thread Duan Andy
> Stefan Agner > Subject: [PATCH] net: fec: fix enet_out clock handling > > When ENET_OUT is being used as reference clock for an external PHY, the > clock must not be disabled while the PHY is active. Otherwise the PHY may > lose its internal state and require a reset

RE: [PATCH] net: fec: fix enet_out clock handling

2015-11-28 Thread Duan Andy
kernel.org; net...@vger.kernel.org; > Stefan Agner > Subject: [PATCH] net: fec: fix enet_out clock handling > > When ENET_OUT is being used as reference clock for an external PHY, the > clock must not be disabled while the PHY is active. Otherwise the PHY may > lose its internal st

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-28 Thread Andrew Lunn
> When MAC is not ready with clocks disabled, it is not necessary to > supply clock for PHY. In fact, PHY also is not ready, why does it > need clock ? How about the case of the "PHY" is actually a switch? You can use the MDIO bus separate from the MAC, you can configure the switch while the MAC

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-27 Thread Michael Heimpold
Hi, Am 27.11.2015 um 14:39 schrieb Lothar Waßmann: When ENET_OUT is being used as reference clock for an external PHY, the clock must not be disabled while the PHY is active. Otherwise the PHY may lose its internal state and require a reset to become functional again. A symptom for this bug is

[PATCH] net: fec: fix enet_out clock handling

2015-11-27 Thread Lothar Waßmann
When ENET_OUT is being used as reference clock for an external PHY, the clock must not be disabled while the PHY is active. Otherwise the PHY may lose its internal state and require a reset to become functional again. A symptom for this bug is a network interface that constantly toggles between

[PATCH] net: fec: fix enet_out clock handling

2015-11-27 Thread Lothar Waßmann
When ENET_OUT is being used as reference clock for an external PHY, the clock must not be disabled while the PHY is active. Otherwise the PHY may lose its internal state and require a reset to become functional again. A symptom for this bug is a network interface that constantly toggles between

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-27 Thread Michael Heimpold
Hi, Am 27.11.2015 um 14:39 schrieb Lothar Waßmann: When ENET_OUT is being used as reference clock for an external PHY, the clock must not be disabled while the PHY is active. Otherwise the PHY may lose its internal state and require a reset to become functional again. A symptom for this bug is