Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Stephen Hemminger
On Thu, 18 Feb 2016 15:35:42 -0500 (EST) David Miller wrote: > From: Linus Lüssing > Date: Mon, 15 Feb 2016 03:07:06 +0100 > > > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff > > *skb, > > if

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Stephen Hemminger
On Thu, 18 Feb 2016 15:35:42 -0500 (EST) David Miller wrote: > From: Linus Lüssing > Date: Mon, 15 Feb 2016 03:07:06 +0100 > > > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff > > *skb, > > if (!pskb_may_pull(skb_chk, offset)) > > goto err; > > >

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread David Miller
From: Linus Lüssing Date: Mon, 15 Feb 2016 03:07:06 +0100 > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff > *skb, > if (!pskb_may_pull(skb_chk, offset)) > goto err; > > - __skb_pull(skb_chk, offset); > +

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread David Miller
From: Linus Lüssing Date: Mon, 15 Feb 2016 03:07:06 +0100 > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff > *skb, > if (!pskb_may_pull(skb_chk, offset)) > goto err; > > - __skb_pull(skb_chk, offset); > + ip_summed = skb->ip_summed; > +

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Linus Lüssing
On Thu, Feb 18, 2016 at 01:51:34PM +0100, Steinar H. Gunderson wrote: > On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote: > > Steinar, can you check whether this fixes the bridge issues you reported on > > bugzilla #99081? Not quite sure whether it is the same as yours as you > > do

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Linus Lüssing
On Thu, Feb 18, 2016 at 01:51:34PM +0100, Steinar H. Gunderson wrote: > On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote: > > Steinar, can you check whether this fixes the bridge issues you reported on > > bugzilla #99081? Not quite sure whether it is the same as yours as you > > do

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Steinar H. Gunderson
On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote: > Steinar, can you check whether this fixes the bridge issues you reported on > bugzilla #99081? Not quite sure whether it is the same as yours as you > do not seem to have any such call traces. It doesn't immediately sound like the

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Steinar H. Gunderson
On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote: > Steinar, can you check whether this fixes the bridge issues you reported on > bugzilla #99081? Not quite sure whether it is the same as yours as you > do not seem to have any such call traces. It doesn't immediately sound like the

[PATCH] net: fix bridge multicast packet checksum validation

2016-02-14 Thread Linus Lüssing
We need to update the skb->csum after pulling the skb, otherwise checksum validation will fail. This fixes multicast packet loss for bridges and splats like the following: [...] [ 43.986968] eth0: hw csum failure [ 43.990344] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 4.4.0 #2 [ 43.996193]

[PATCH] net: fix bridge multicast packet checksum validation

2016-02-14 Thread Linus Lüssing
We need to update the skb->csum after pulling the skb, otherwise checksum validation will fail. This fixes multicast packet loss for bridges and splats like the following: [...] [ 43.986968] eth0: hw csum failure [ 43.990344] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 4.4.0 #2 [ 43.996193]