Re: [PATCH] net: fix sk_page_frag() recursion from memory reclaim

2019-10-22 Thread Jakub Kicinski
On Sat, 19 Oct 2019 14:25:57 -0700, Eric Dumazet wrote: > On 10/19/19 2:18 PM, Tejun Heo wrote: > > > Whatever works is fine by me. gfpflags_allow_blocking() is clearer > > than testing __GFP_DIRECT_RECLAIM directly tho. Maybe a better way is > > introducing a new gfpflags_ helper? > >

Re: [PATCH] net: fix sk_page_frag() recursion from memory reclaim

2019-10-19 Thread Eric Dumazet
On 10/19/19 2:18 PM, Tejun Heo wrote: > Whatever works is fine by me. gfpflags_allow_blocking() is clearer > than testing __GFP_DIRECT_RECLAIM directly tho. Maybe a better way is > introducing a new gfpflags_ helper? Sounds good to me !

Re: [PATCH] net: fix sk_page_frag() recursion from memory reclaim

2019-10-19 Thread Tejun Heo
Hello, On Sat, Oct 19, 2019 at 11:15:28AM -0700, Eric Dumazet wrote: > It seems compiler generates better code with : > > diff --git a/include/net/sock.h b/include/net/sock.h > index > ab905c4b1f0efd42ebdcae333b3f0a2c7c1b2248..56de6ac99f0952bd0bc003353c094ce3a5a852f4 > 100644 > ---

Re: [PATCH] net: fix sk_page_frag() recursion from memory reclaim

2019-10-19 Thread Eric Dumazet
On 10/19/19 10:01 AM, Tejun Heo wrote: > From f0335a5d14d3596d36e3ffddb2fd4fa0dc6ca9c2 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Sat, 19 Oct 2019 09:10:57 -0700 > > sk_page_frag() optimizes skb_frag allocations by using per-task > skb_frag cache when it knows it's the only user. The

[PATCH] net: fix sk_page_frag() recursion from memory reclaim

2019-10-19 Thread Tejun Heo
>From f0335a5d14d3596d36e3ffddb2fd4fa0dc6ca9c2 Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Sat, 19 Oct 2019 09:10:57 -0700 sk_page_frag() optimizes skb_frag allocations by using per-task skb_frag cache when it knows it's the only user. The condition is determined by seeing whether the socket