Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-28 Thread Joel Stanley
On Thu, 22 Oct 2020 at 07:41, Benjamin Herrenschmidt wrote: > > On Wed, 2020-10-21 at 14:40 +0200, Arnd Bergmann wrote: > > On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote: > > > > > > > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c > > > b/drivers/net/ethernet/faraday/ftgmac100.c

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-28 Thread Arnd Bergmann
On Wed, Oct 28, 2020 at 5:47 AM Joel Stanley wrote: > > On Thu, 22 Oct 2020 at 07:41, Benjamin Herrenschmidt > wrote: > > > > > > > > + /* Ensure the descriptor config is visible before setting the tx > > > > +* pointer. > > > > +*/ > > > > + smp_wmb(); > > > > + > >

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-22 Thread Benjamin Herrenschmidt
On Wed, 2020-10-21 at 14:40 +0200, Arnd Bergmann wrote: > On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote: > > > > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c > > b/drivers/net/ethernet/faraday/ftgmac100.c > > index 331d4bdd4a67..15cdfeb135b0 100644 > > ---

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-22 Thread Benjamin Herrenschmidt
On Wed, 2020-10-21 at 08:18 +, David Laight wrote: > From: Benjamin Herrenschmidt > > Sent: 21 October 2020 01:00 > > > > On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote: > > > We must ensure the tx descriptor updates are visible before updating > > > the tx pointer. > > > > > > This

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-22 Thread Joel Stanley
On Wed, 21 Oct 2020 at 12:40, Arnd Bergmann wrote: > > On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote: > > > > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c > > b/drivers/net/ethernet/faraday/ftgmac100.c > > index 331d4bdd4a67..15cdfeb135b0 100644 > > ---

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-21 Thread Arnd Bergmann
On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote: > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c > b/drivers/net/ethernet/faraday/ftgmac100.c > index 331d4bdd4a67..15cdfeb135b0 100644 > --- a/drivers/net/ethernet/faraday/ftgmac100.c > +++ b/drivers/net/ethernet/faraday/ftgmac100.c

RE: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-21 Thread David Laight
From: Benjamin Herrenschmidt > Sent: 21 October 2020 01:00 > > On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote: > > We must ensure the tx descriptor updates are visible before updating > > the tx pointer. > > > > This resolves the tx hangs observed on the 2600 when running iperf: > > To

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-20 Thread Joel Stanley
On Wed, 21 Oct 2020 at 00:00, Benjamin Herrenschmidt wrote: > > On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote: > > We must ensure the tx descriptor updates are visible before updating > > the tx pointer. > > > > This resolves the tx hangs observed on the 2600 when running iperf: > > To

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-20 Thread Benjamin Herrenschmidt
On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote: > We must ensure the tx descriptor updates are visible before updating > the tx pointer. > > This resolves the tx hangs observed on the 2600 when running iperf: To clarify the comment here. This doesn't ensure they are visible to the

[PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-20 Thread Joel Stanley
We must ensure the tx descriptor updates are visible before updating the tx pointer. This resolves the tx hangs observed on the 2600 when running iperf: root@ast2600:~# iperf3 -c 192.168.86.146 -R Connecting to host 192.168.86.146, port 5201 Reverse mode, remote host 192.168.86.146 is sending [