Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-25 Thread Luis R. Rodriguez
On Tue, Feb 25, 2014 at 2:39 PM, Florian Fainelli wrote: > 2014-02-25 14:19 GMT-08:00 Luis R. Rodriguez : >> On Mon, Feb 24, 2014 at 9:37 PM, Florian Fainelli >> wrote: >>> Le lundi 24 février 2014, 23:53:43 David Miller a écrit : They are visible to userspace via sysfs. >>> >>> In /sys/cla

Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-25 Thread Florian Fainelli
2014-02-25 14:19 GMT-08:00 Luis R. Rodriguez : > On Mon, Feb 24, 2014 at 9:37 PM, Florian Fainelli > wrote: >> Le lundi 24 février 2014, 23:53:43 David Miller a écrit : >>> They are visible to userspace via sysfs. >> >> In /sys/class/net/*/flags, although we are lacking quite a lot of >> documen

Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-25 Thread Luis R. Rodriguez
On Mon, Feb 24, 2014 at 9:37 PM, Florian Fainelli wrote: > Le lundi 24 février 2014, 23:53:43 David Miller a écrit : >> They are visible to userspace via sysfs. > > In /sys/class/net/*/flags, although we are lacking quite a lot of > documentation > for the exported attributes there. I only see d

Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-25 Thread Ben Hutchings
On Mon, 2014-02-24 at 23:53 -0500, David Miller wrote: > From: Ben Hutchings > Date: Tue, 25 Feb 2014 02:11:05 + > > > On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote: > >> From: "Luis R. Rodriguez" > >> > >> --- > >> include/uapi/linux/if.h | 201 > >> +

Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-24 Thread Luis R. Rodriguez
On Mon, Feb 24, 2014 at 09:37:34PM -0800, Florian Fainelli wrote: > Le lundi 24 février 2014, 23:53:43 David Miller a écrit : > > From: Ben Hutchings > > Date: Tue, 25 Feb 2014 02:11:05 + > > > > > On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote: > > >> From: "Luis R. Rodriguez" >

Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-24 Thread Florian Fainelli
Le lundi 24 février 2014, 23:53:43 David Miller a écrit : > From: Ben Hutchings > Date: Tue, 25 Feb 2014 02:11:05 + > > > On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote: > >> From: "Luis R. Rodriguez" > >> > >> --- > >> > >> include/uapi/linux/if.h | 201 > >>

Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-24 Thread David Miller
From: Ben Hutchings Date: Tue, 25 Feb 2014 02:11:05 + > On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" >> >> --- >> include/uapi/linux/if.h | 201 >> +++- >> 1 file changed, 149 insertions(+), 52 deletio

Re: [PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-24 Thread Ben Hutchings
On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > We have documentation for these flags but they're scattered > all over the place. #defines don't allow documentation to be > written easily so to help to start bringing some documentation > together use th

[PATCH] net: kdoc struct net_device flags and priv_flags

2014-02-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We have documentation for these flags but they're scattered all over the place. #defines don't allow documentation to be written easily so to help to start bringing some documentation together use the enums kdoc practice but keep the defines to allow userspace to be able