Re: [PATCH] net: mellanox: mlxsw: fix error return code of mlxsw_sp_router_nve_promote_decap()

2021-03-07 Thread Ido Schimmel
On Sat, Mar 06, 2021 at 03:32:39PM +0100, Heiner Kallweit wrote: > On 06.03.2021 15:07, Jia-Ju Bai wrote: > > When fib_entry is NULL, no error return code of > > mlxsw_sp_router_nve_promote_decap() is assigned. > > To fix this bug, err is assigned with -EINVAL in this case. > > > Again, are you

Re: [PATCH] net: mellanox: mlxsw: fix error return code of mlxsw_sp_router_nve_promote_decap()

2021-03-06 Thread Heiner Kallweit
On 06.03.2021 15:07, Jia-Ju Bai wrote: > When fib_entry is NULL, no error return code of > mlxsw_sp_router_nve_promote_decap() is assigned. > To fix this bug, err is assigned with -EINVAL in this case. > Again, are you sure this is a bug? To me it looks like it is intentional to not return an

[PATCH] net: mellanox: mlxsw: fix error return code of mlxsw_sp_router_nve_promote_decap()

2021-03-06 Thread Jia-Ju Bai
When fib_entry is NULL, no error return code of mlxsw_sp_router_nve_promote_decap() is assigned. To fix this bug, err is assigned with -EINVAL in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 +++- 1 file changed, 3