Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-24 Thread Sergei Shtylyov
On 03/24/2016 01:10 PM, Sebastian Frias wrote: What I don't understand is why the link_change_notify() method ptr is populated for all 3 supported chips while only being needed on 8030... You are right. I made the patch but I'm unsure about it because it could conflict with yours. I

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-24 Thread Sergei Shtylyov
On 03/24/2016 01:10 PM, Sebastian Frias wrote: What I don't understand is why the link_change_notify() method ptr is populated for all 3 supported chips while only being needed on 8030... You are right. I made the patch but I'm unsure about it because it could conflict with yours. I

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-24 Thread Sebastian Frias
Hi Sergei, >>What I don't understand is why the link_change_notify() method ptr is >> populated for all 3 supported chips while only being needed on 8030... > > You are right. I made the patch but I'm unsure about it because it could conflict with yours. I mean, I think you submitted a

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-24 Thread Sebastian Frias
Hi Sergei, >>What I don't understand is why the link_change_notify() method ptr is >> populated for all 3 supported chips while only being needed on 8030... > > You are right. I made the patch but I'm unsure about it because it could conflict with yours. I mean, I think you submitted a

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-24 Thread Sebastian Frias
Hi Sergei, On 03/23/2016 08:42 PM, Sergei Shtylyov wrote: > Hello. > > On 03/23/2016 01:49 PM, Sebastian Frias wrote: > >> This removes the dependency on GPIOLIB for non faulty PHYs. >> >> Indeed, without this patch, if GPIOLIB is not selected >> devm_gpiod_get_optional() will return -ENOSYS

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-24 Thread Sebastian Frias
Hi Sergei, On 03/23/2016 08:42 PM, Sergei Shtylyov wrote: > Hello. > > On 03/23/2016 01:49 PM, Sebastian Frias wrote: > >> This removes the dependency on GPIOLIB for non faulty PHYs. >> >> Indeed, without this patch, if GPIOLIB is not selected >> devm_gpiod_get_optional() will return -ENOSYS

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-23 Thread Sergei Shtylyov
Hello. On 03/23/2016 01:49 PM, Sebastian Frias wrote: This removes the dependency on GPIOLIB for non faulty PHYs. Indeed, without this patch, if GPIOLIB is not selected devm_gpiod_get_optional() will return -ENOSYS and the driver probe call will fail, regardless of the actual PHY hardware.

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-23 Thread Sergei Shtylyov
Hello. On 03/23/2016 01:49 PM, Sebastian Frias wrote: This removes the dependency on GPIOLIB for non faulty PHYs. Indeed, without this patch, if GPIOLIB is not selected devm_gpiod_get_optional() will return -ENOSYS and the driver probe call will fail, regardless of the actual PHY hardware.

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-23 Thread David Miller
From: Sebastian Frias Date: Wed, 23 Mar 2016 11:49:09 +0100 > This removes the dependency on GPIOLIB for non faulty PHYs. > > Indeed, without this patch, if GPIOLIB is not selected > devm_gpiod_get_optional() will return -ENOSYS and the driver probe > call will fail,

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-23 Thread David Miller
From: Sebastian Frias Date: Wed, 23 Mar 2016 11:49:09 +0100 > This removes the dependency on GPIOLIB for non faulty PHYs. > > Indeed, without this patch, if GPIOLIB is not selected > devm_gpiod_get_optional() will return -ENOSYS and the driver probe > call will fail, regardless of the actual

[PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-23 Thread Sebastian Frias
This removes the dependency on GPIOLIB for non faulty PHYs. Indeed, without this patch, if GPIOLIB is not selected devm_gpiod_get_optional() will return -ENOSYS and the driver probe call will fail, regardless of the actual PHY hardware. Out of the 3 PHYs supported by this driver (AT8030, AT8031,

[PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

2016-03-23 Thread Sebastian Frias
This removes the dependency on GPIOLIB for non faulty PHYs. Indeed, without this patch, if GPIOLIB is not selected devm_gpiod_get_optional() will return -ENOSYS and the driver probe call will fail, regardless of the actual PHY hardware. Out of the 3 PHYs supported by this driver (AT8030, AT8031,