Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Roger Quadros
Hi, On 19/04/17 19:53, Alexander Kochetkov wrote: > >> 19 апр. 2017 г., в 19:32, Florian Fainelli написал(а): >> >> http://patchwork.ozlabs.org/patch/743773/ >> >> Roger can you also test Alexander's patch? This patch fixes my problem and doesn't have the 1 second delay

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Roger Quadros
Hi, On 19/04/17 19:53, Alexander Kochetkov wrote: > >> 19 апр. 2017 г., в 19:32, Florian Fainelli написал(а): >> >> http://patchwork.ozlabs.org/patch/743773/ >> >> Roger can you also test Alexander's patch? This patch fixes my problem and doesn't have the 1 second delay that my patch had.

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Sergei Shtylyov
Hello! On 04/19/2017 04:46 PM, Alexander Kochetkov wrote: The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using interrupts. During power-up cycle the PHY do auto-negotiation, generate interrupt and set BMSR_ANEGCOMPLETE flag. Interrupt is handled by PHY state machine but doesn't

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Sergei Shtylyov
Hello! On 04/19/2017 04:46 PM, Alexander Kochetkov wrote: The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using interrupts. During power-up cycle the PHY do auto-negotiation, generate interrupt and set BMSR_ANEGCOMPLETE flag. Interrupt is handled by PHY state machine but doesn't

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
> 19 апр. 2017 г., в 19:32, Florian Fainelli написал(а): > > http://patchwork.ozlabs.org/patch/743773/ > > Roger can you also test Alexander's patch? If MAC use phy_start_aneg() instead of phy_start() my patch will not work as expected. Roger, if patch don’t work for you

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
> 19 апр. 2017 г., в 19:32, Florian Fainelli написал(а): > > http://patchwork.ozlabs.org/patch/743773/ > > Roger can you also test Alexander's patch? If MAC use phy_start_aneg() instead of phy_start() my patch will not work as expected. Roger, if patch don’t work for you please check what MAC

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Florian Fainelli
On 04/19/2017 07:05 AM, Alexander Kochetkov wrote: > Just found similar problem fixed in another PHY. See commit 99f81afc139c > ("phy: micrel: Disable auto negotiation on startup») This specific commit was really a "this works for me, but I have not investigated what needs fixing in PHYLIB".

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Florian Fainelli
On 04/19/2017 07:05 AM, Alexander Kochetkov wrote: > Just found similar problem fixed in another PHY. See commit 99f81afc139c > ("phy: micrel: Disable auto negotiation on startup») This specific commit was really a "this works for me, but I have not investigated what needs fixing in PHYLIB".

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
Just found similar problem fixed in another PHY. See commit 99f81afc139c ("phy: micrel: Disable auto negotiation on startup») > 19 апр. 2017 г., в 16:46, Alexander Kochetkov > написал(а): > > The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using > interrupts.

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
Just found similar problem fixed in another PHY. See commit 99f81afc139c ("phy: micrel: Disable auto negotiation on startup») > 19 апр. 2017 г., в 16:46, Alexander Kochetkov > написал(а): > > The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using > interrupts. During power-up

[PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using interrupts. During power-up cycle the PHY do auto-negotiation, generate interrupt and set BMSR_ANEGCOMPLETE flag. Interrupt is handled by PHY state machine but doesn't update link because PHY is in PHY_READY state. After some time

[PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using interrupts. During power-up cycle the PHY do auto-negotiation, generate interrupt and set BMSR_ANEGCOMPLETE flag. Interrupt is handled by PHY state machine but doesn't update link because PHY is in PHY_READY state. After some time