Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Quoting David Howells : What is the reason? Visual separation. Thanks for clarifying. -- Gustavo A. R. Silva

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Quoting David Howells : What is the reason? Visual separation. Thanks for clarifying. -- Gustavo A. R. Silva

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Gustavo A. R. Silva wrote: > > No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's > > there for a reason. > > > > What is the reason? Visual separation. David

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Gustavo A. R. Silva wrote: > > No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's > > there for a reason. > > > > What is the reason? Visual separation. David

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Quoting David Howells : Gustavo A. R. Silva wrote: + /* fall through */ All new comments in rxrpc should begin with a capital letter; I'm switching to this as I modify the lines with comments on. Fix checkpatch or gcc or

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Quoting David Howells : Gustavo A. R. Silva wrote: + /* fall through */ All new comments in rxrpc should begin with a capital letter; I'm switching to this as I modify the lines with comments on. Fix checkpatch or gcc or whatever takes -Wimplicit-fallthrough to stop

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Gustavo A. R. Silva wrote: > + /* fall through */ All new comments in rxrpc should begin with a capital letter; I'm switching to this as I modify the lines with comments on. Fix checkpatch or gcc or whatever takes -Wimplicit-fallthrough to stop being silly.

Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

Gustavo A. R. Silva wrote: > + /* fall through */ All new comments in rxrpc should begin with a capital letter; I'm switching to this as I modify the lines with comments on. Fix checkpatch or gcc or whatever takes -Wimplicit-fallthrough to stop being silly. > - /* Fall

[PATCH] net: rxrpc: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to

[PATCH] net: rxrpc: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to fall through.