Re: [PATCH] net: sched: don't disable bh when accessing action idr

2018-05-19 Thread David Miller
From: Vlad Buslov Date: Sat, 19 May 2018 13:12:49 +0300 > > On Sat 19 May 2018 at 02:59, Cong Wang wrote: >> On Fri, May 18, 2018 at 8:45 AM, Vlad Buslov wrote: >>> Underlying implementation of action map has changed and doesn't require >>> disabling bh anymore. Replace all action idr spinlock

Re: [PATCH] net: sched: don't disable bh when accessing action idr

2018-05-19 Thread Vlad Buslov
On Sat 19 May 2018 at 02:59, Cong Wang wrote: > On Fri, May 18, 2018 at 8:45 AM, Vlad Buslov wrote: >> Underlying implementation of action map has changed and doesn't require >> disabling bh anymore. Replace all action idr spinlock usage with regular >> calls that do not disable bh. > > Please e

Re: [PATCH] net: sched: don't disable bh when accessing action idr

2018-05-18 Thread Cong Wang
On Fri, May 18, 2018 at 8:45 AM, Vlad Buslov wrote: > Underlying implementation of action map has changed and doesn't require > disabling bh anymore. Replace all action idr spinlock usage with regular > calls that do not disable bh. Please explain explicitly why it is not required, don't let peop

[PATCH] net: sched: don't disable bh when accessing action idr

2018-05-18 Thread Vlad Buslov
Underlying implementation of action map has changed and doesn't require disabling bh anymore. Replace all action idr spinlock usage with regular calls that do not disable bh. Signed-off-by: Vlad Buslov --- net/sched/act_api.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deleti