Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-26 Thread Chen-Yu Tsai
On Tue, Aug 26, 2014 at 9:20 PM, Giuseppe CAVALLARO wrote: > On 8/26/2014 2:35 PM, Vince Bridgers wrote: >> >> Hi Peppe, >> In the Synopsys EMAC case, carrier sense is used to stop transmitting if no carrier is sensed during a transmission. This is only useful if the media in u

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-26 Thread Ley Foon Tan
On Tue, Aug 26, 2014 at 9:20 PM, Giuseppe CAVALLARO wrote: >>> >>> >>> >>> Indeed this is what I had done in the patch. >>> >>> >>> http://git.stlinux.com/?p=stm/linux-sh4-2.6.32.y.git;a=commit;h=b0b863bf65c36dc593f6b7b4b418394fd880dae2 >>> >>> Also in case of carrier sense the frame will be drop

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-26 Thread Giuseppe CAVALLARO
On 8/26/2014 2:35 PM, Vince Bridgers wrote: Hi Peppe, In the Synopsys EMAC case, carrier sense is used to stop transmitting if no carrier is sensed during a transmission. This is only useful if the media in use is true half duplex media (like obsolete 10Base2 or 10Base5). If no one in using tr

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-26 Thread Vince Bridgers
Hi Peppe, >> >> In the Synopsys EMAC case, carrier sense is used to stop transmitting >> if no carrier is sensed during a transmission. This is only useful if >> the media in use is true half duplex media (like obsolete 10Base2 or >> 10Base5). If no one in using true half duplex media, then is it

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-25 Thread Giuseppe CAVALLARO
On 8/25/2014 5:10 PM, Vince Bridgers wrote: Hi, On Mon, Aug 25, 2014 at 7:51 AM, Giuseppe CAVALLARO wrote: On 8/25/2014 2:34 PM, Chen-Yu Tsai wrote: Hi, On Mon, Aug 25, 2014 at 7:50 PM, Ley Foon Tan wrote: This patch add the option to enable DCRS bit in GMAC control register. Default is

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-25 Thread Vince Bridgers
Hi, On Mon, Aug 25, 2014 at 7:51 AM, Giuseppe CAVALLARO wrote: > On 8/25/2014 2:34 PM, Chen-Yu Tsai wrote: >> >> Hi, >> >> On Mon, Aug 25, 2014 at 7:50 PM, Ley Foon Tan wrote: >>> >>> This patch add the option to enable DCRS bit in GMAC control register. >>> Default is disabled if snps,dcrs is n

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-25 Thread Giuseppe CAVALLARO
On 8/25/2014 2:34 PM, Chen-Yu Tsai wrote: Hi, On Mon, Aug 25, 2014 at 7:50 PM, Ley Foon Tan wrote: This patch add the option to enable DCRS bit in GMAC control register. Default is disabled if snps,dcrs is not defined. For MII, Carrier Sense (CRS) must be asserted during transmission whereas

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-25 Thread Chen-Yu Tsai
Hi, On Mon, Aug 25, 2014 at 7:50 PM, Ley Foon Tan wrote: > This patch add the option to enable DCRS bit in GMAC control register. > Default is disabled if snps,dcrs is not defined. > > For MII, Carrier Sense (CRS) must be asserted during transmission > whereas in RGMII, CRS is not. RGMII does not

Re: [PATCH] net: stmmac: add dcrs parameter

2014-08-25 Thread Giuseppe CAVALLARO
Hello On 8/25/2014 1:50 PM, Ley Foon Tan wrote: This patch add the option to enable DCRS bit in GMAC control register. Default is disabled if snps,dcrs is not defined. For MII, Carrier Sense (CRS) must be asserted during transmission whereas in RGMII, CRS is not. RGMII does not provide a way to

[PATCH] net: stmmac: add dcrs parameter

2014-08-25 Thread Ley Foon Tan
This patch add the option to enable DCRS bit in GMAC control register. Default is disabled if snps,dcrs is not defined. For MII, Carrier Sense (CRS) must be asserted during transmission whereas in RGMII, CRS is not. RGMII does not provide a way to signal loss of carrier during a transmission. Whe