Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

2015-03-25 Thread Alexey Kodanev
Hi! On 03/23/2015 04:52 PM, Eric Dumazet wrote: On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote: Regression introduced by commit 2dc49d1680. tcp_v6_fill_cb() will be called twice if socket's state changes from TCP_TIME_WAIT to TCP_LISTEN. That can result in performance loss and control

Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

2015-03-23 Thread Alexey Kodanev
Hi Eric, On 03/23/2015 05:38 PM, Eric Dumazet wrote: On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote: \ @@ -1538,7 +1525,7 @@ do_time_wait: &ipv6_hdr(skb)->saddr, th->source, &ipv6_hdr(skb)->daddr,

Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

2015-03-23 Thread Eric Dumazet
On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote: \ > @@ -1538,7 +1525,7 @@ do_time_wait: > &ipv6_hdr(skb)->saddr, th->source, > &ipv6_hdr(skb)->daddr, > ntohs(th->de

Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

2015-03-23 Thread Eric Dumazet
On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote: > Regression introduced by commit 2dc49d1680. > > tcp_v6_fill_cb() will be called twice if socket's state changes from > TCP_TIME_WAIT to TCP_LISTEN. That can result in performance loss and > control buffer data corruption because in the sec

[PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

2015-03-23 Thread Alexey Kodanev
Regression introduced by commit 2dc49d1680. tcp_v6_fill_cb() will be called twice if socket's state changes from TCP_TIME_WAIT to TCP_LISTEN. That can result in performance loss and control buffer data corruption because in the second tcp_v6_fill_cb() it's not copying the 'header' anymore, but 'se