Re: [PATCH] net: tsi108: Prevent compiler warning

2013-09-19 Thread Thierry Reding
On Wed, Sep 18, 2013 at 12:38:53PM -0400, David Miller wrote: > From: Thierry Reding > Date: Wed, 18 Sep 2013 14:49:55 +0200 > > > The dump_eth_one() function is only used if DEBUG is enabled, so protect > > it by a corresponding #ifdef DEBUG block. > > > > Signed-off-by: Thierry Reding > > I

Re: [PATCH] net: tsi108: Prevent compiler warning

2013-09-19 Thread Thierry Reding
On Wed, Sep 18, 2013 at 12:38:53PM -0400, David Miller wrote: From: Thierry Reding thierry.red...@gmail.com Date: Wed, 18 Sep 2013 14:49:55 +0200 The dump_eth_one() function is only used if DEBUG is enabled, so protect it by a corresponding #ifdef DEBUG block. Signed-off-by: Thierry

Re: [PATCH] net: tsi108: Prevent compiler warning

2013-09-18 Thread David Miller
From: Thierry Reding Date: Wed, 18 Sep 2013 14:49:55 +0200 > The dump_eth_one() function is only used if DEBUG is enabled, so protect > it by a corresponding #ifdef DEBUG block. > > Signed-off-by: Thierry Reding I would prefer that this function and the one call site is simply removed

[PATCH] net: tsi108: Prevent compiler warning

2013-09-18 Thread Thierry Reding
The dump_eth_one() function is only used if DEBUG is enabled, so protect it by a corresponding #ifdef DEBUG block. Signed-off-by: Thierry Reding --- drivers/net/ethernet/tundra/tsi108_eth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/tundra/tsi108_eth.c

[PATCH] net: tsi108: Prevent compiler warning

2013-09-18 Thread Thierry Reding
The dump_eth_one() function is only used if DEBUG is enabled, so protect it by a corresponding #ifdef DEBUG block. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/net/ethernet/tundra/tsi108_eth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] net: tsi108: Prevent compiler warning

2013-09-18 Thread David Miller
From: Thierry Reding thierry.red...@gmail.com Date: Wed, 18 Sep 2013 14:49:55 +0200 The dump_eth_one() function is only used if DEBUG is enabled, so protect it by a corresponding #ifdef DEBUG block. Signed-off-by: Thierry Reding tred...@nvidia.com I would prefer that this function and the