RE: [PATCH] net: untag pointer in sockptr_is_kernel

2020-08-12 Thread David Laight
From: Miles Chen > Sent: 12 August 2020 10:16 > > On Tue, 2020-08-11 at 11:44 +, David Laight wrote: > > > On Tue, Aug 11, 2020 at 06:27:04PM +0800, Miles Chen wrote: > > > > From: Miles Chen > > > > > > > > sockptr_is_kernel() uses (sockptr.kernel >= TASK_SIZE) to tell > > > > if the

Re: [PATCH] net: untag pointer in sockptr_is_kernel

2020-08-12 Thread Miles Chen
On Tue, 2020-08-11 at 20:28 +0800, kernel test robot wrote: > Hi Miles, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > [also build test ERROR on linus/master] > [cannot apply to net/master hch-configfs/for-next sparc-next/master v5.8 >

RE: [PATCH] net: untag pointer in sockptr_is_kernel

2020-08-12 Thread Miles Chen
On Tue, 2020-08-11 at 11:44 +, David Laight wrote: > > On Tue, Aug 11, 2020 at 06:27:04PM +0800, Miles Chen wrote: > > > From: Miles Chen > > > > > > sockptr_is_kernel() uses (sockptr.kernel >= TASK_SIZE) to tell > > > if the pointer is kernel space or user space. When user space uses > > >

Re: [PATCH] net: untag pointer in sockptr_is_kernel

2020-08-11 Thread kernel test robot
Hi Miles, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on linus/master] [cannot apply to net/master hch-configfs/for-next sparc-next/master v5.8 next-20200811] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH] net: untag pointer in sockptr_is_kernel

2020-08-11 Thread kernel test robot
Hi Miles, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on linus/master] [cannot apply to net/master hch-configfs/for-next sparc-next/master v5.8 next-20200811] [If your patch is applied to the wrong git tree, kindly drop us

RE: [PATCH] net: untag pointer in sockptr_is_kernel

2020-08-11 Thread David Laight
> On Tue, Aug 11, 2020 at 06:27:04PM +0800, Miles Chen wrote: > > From: Miles Chen > > > > sockptr_is_kernel() uses (sockptr.kernel >= TASK_SIZE) to tell > > if the pointer is kernel space or user space. When user space uses > > the "top byte ignored" feature such as HWAsan, we must untag > > the

Re: [PATCH] net: untag pointer in sockptr_is_kernel

2020-08-11 Thread Christoph Hellwig
On Tue, Aug 11, 2020 at 06:27:04PM +0800, Miles Chen wrote: > From: Miles Chen > > sockptr_is_kernel() uses (sockptr.kernel >= TASK_SIZE) to tell > if the pointer is kernel space or user space. When user space uses > the "top byte ignored" feature such as HWAsan, we must untag > the pointer

[PATCH] net: untag pointer in sockptr_is_kernel

2020-08-11 Thread Miles Chen
From: Miles Chen sockptr_is_kernel() uses (sockptr.kernel >= TASK_SIZE) to tell if the pointer is kernel space or user space. When user space uses the "top byte ignored" feature such as HWAsan, we must untag the pointer before checking against TASK_SIZE. sockptr_is_kernel() will view a tagged