Re: [PATCH] net: use raw_cpu ops in snmp stats bh

2014-03-06 Thread Sergey Senozhatsky
Hello, On Thu, Mar 6, 2014 at 9:13 PM, David Miller wrote: > From: Sergey Senozhatsky > Date: Thu, 6 Mar 2014 15:55:36 +0300 > >> Commit a25982c15ae52 ("percpu: add preemption checks to __this_cpu >> ops") added preemption checks to __this_cpu ops, which are used in >> SNMP_INC_STATS_BH() and S

Re: [PATCH] net: use raw_cpu ops in snmp stats bh

2014-03-06 Thread David Miller
From: Eric Dumazet Date: Thu, 06 Mar 2014 07:04:32 -0800 > On Thu, 2014-03-06 at 06:44 -0800, Eric Dumazet wrote: > >> I think you missed a lot of mails sent by Chrisoph Lameter recently... > > s/Chrisoph/Christoph/ > > Appropriate fix would be the following one, please submit this formally. >

Re: [PATCH] net: use raw_cpu ops in snmp stats bh

2014-03-06 Thread David Miller
From: Sergey Senozhatsky Date: Thu, 6 Mar 2014 15:55:36 +0300 > Commit a25982c15ae52 ("percpu: add preemption checks to __this_cpu > ops") added preemption checks to __this_cpu ops, which are used in > SNMP_INC_STATS_BH() and SNMP_ADD_STATS_BH(), resulting in following > warnings: > > BUG: usin

Re: [PATCH] net: use raw_cpu ops in snmp stats bh

2014-03-06 Thread Eric Dumazet
On Thu, 2014-03-06 at 06:44 -0800, Eric Dumazet wrote: > I think you missed a lot of mails sent by Chrisoph Lameter recently... s/Chrisoph/Christoph/ Appropriate fix would be the following one, please submit this formally. Fixes: f19c29e3e391 ("tcp: snmp stats for Fast Open, SYN rtx, and data

Re: [PATCH] net: use raw_cpu ops in snmp stats bh

2014-03-06 Thread Eric Dumazet
On Thu, 2014-03-06 at 15:55 +0300, Sergey Senozhatsky wrote: > Commit a25982c15ae52 ("percpu: add preemption checks to __this_cpu > ops") added preemption checks to __this_cpu ops, which are used in > SNMP_INC_STATS_BH() and SNMP_ADD_STATS_BH(), resulting in following > warnings: > > BUG: using __

[PATCH] net: use raw_cpu ops in snmp stats bh

2014-03-06 Thread Sergey Senozhatsky
Commit a25982c15ae52 ("percpu: add preemption checks to __this_cpu ops") added preemption checks to __this_cpu ops, which are used in SNMP_INC_STATS_BH() and SNMP_ADD_STATS_BH(), resulting in following warnings: BUG: using __this_cpu_add() in preemptible [] code: ssh/4661 caller is __this_