Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

2015-01-05 7:34 GMT+01:00 Rafał Miłecki : > On 3 January 2015 at 13:28, Rickard Strandqvist > wrote: >> 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : >>> >>> 1) I gave you Ack for the changes >>> 2) You could drop "net: wireless: " or better use something Sedat proposed >> >> Nice, yes I miss the Ack

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On 3 January 2015 at 13:28, Rickard Strandqvist wrote: > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : >> >> 1) I gave you Ack for the changes >> 2) You could drop "net: wireless: " or better use something Sedat proposed > > Nice, yes I miss the Ack :) > > I just got one more complaining about my sub

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

2015-01-03 15:51 GMT+01:00 Sedat Dilek : > On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist > wrote: > [ ... ] >>> > I just got one more complaining about my subject-line in "net: wireless: " >>> > I use some sed call for this, so it's easy to fix. I will now remove that >>> > part hereinafter.

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist wrote: [ ... ] >> > I just got one more complaining about my subject-line in "net: wireless: " >> > I use some sed call for this, so it's easy to fix. I will now remove that >> > part hereinafter. >> > I check in Documentation/ but did not find a

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

2015-01-03 14:19 GMT+01:00 Sedat Dilek : > > On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist > wrote: > > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : > >> > >> On 2 January 2015 at 18:46, Rickard Strandqvist > >> wrote: > >> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek : > >> >> > >> >> On Fri, Ja

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist wrote: > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : >> >> On 2 January 2015 at 18:46, Rickard Strandqvist >> wrote: >> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek : >> >> >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: >> >> > On 2 Janu

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On 2 January 2015 at 18:46, Rickard Strandqvist wrote: > 2015-01-02 13:14 GMT+01:00 Sedat Dilek : >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: >> > On 2 January 2015 at 13:05, Rafał Miłecki wrote: >> >> On 1 January 2015 at 16:46, Rickard Strandqvist >> >> wrote: >> >>> Remove the

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: > On 2 January 2015 at 13:05, Rafał Miłecki wrote: >> On 1 January 2015 at 16:46, Rickard Strandqvist >> wrote: >>> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. >>> >>> This was partially found by using a static c

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On 2 January 2015 at 13:05, Rafał Miłecki wrote: > On 1 January 2015 at 16:46, Rickard Strandqvist > wrote: >> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. >> >> This was partially found by using a static code analysis program called >> cppcheck. > > It seems to be

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On 1 January 2015 at 16:46, Rickard Strandqvist wrote: > Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not

[PATCH] net: wireless: b43legacy: radio.c: Remove unused function

Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/b43legacy/radio.c | 19 --- drivers/net/wireless/b43legacy/