[PATCH net 5/7] selftests/net: Print the testing side in unsigned-md5

2025-03-12 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> As both client and server print the same test name on failure or pass, add "[server]" so that it's more obvious from a log which side printed "ok" or "not ok". Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- tools/testing/selftests/net/tcp_ao/

Re: [PATCH net 5/6] net: dsa: ksz: fix wrong pvid

2021-01-13 Thread Vladimir Oltean
On Wed, Jan 13, 2021 at 01:45:21PM +0100, Gilles DOFFE wrote: > A logical 'or' was performed until now. > So if vlan 1 is the current pvid and vlan 20 is set as the new one, > vlan 21 is the new pvid. > This commit fixes this by setting the right mask to set the new pvid. > > Signed-off-by: Gilles

Re: [PATCH net 5/6] net: dsa: ksz: fix wrong pvid

2021-01-13 Thread Florian Fainelli
On 1/13/21 4:45 AM, Gilles DOFFE wrote: > A logical 'or' was performed until now. > So if vlan 1 is the current pvid and vlan 20 is set as the new one, > vlan 21 is the new pvid. > This commit fixes this by setting the right mask to set the new pvid. > > Signed-off-by: Gilles DOFFE Looks about r

[PATCH net 5/6] net: dsa: ksz: fix wrong pvid

2021-01-13 Thread Gilles DOFFE
A logical 'or' was performed until now. So if vlan 1 is the current pvid and vlan 20 is set as the new one, vlan 21 is the new pvid. This commit fixes this by setting the right mask to set the new pvid. Signed-off-by: Gilles DOFFE --- drivers/net/dsa/microchip/ksz8795.c | 4 ++-- 1 file changed,

Re: [PATCH net 5/5] net: ipa: avoid going past end of resource group array

2020-10-28 Thread Willem de Bruijn
> >> + /* We program at most 6 source or destination resource group > >> limits */ > >> + BUILD_BUG_ON(IPA_RESOURCE_GROUP_SRC_MAX > 6); > >> + > >> group_count = ipa_resource_group_src_count(ipa->version); > >> - if (!group_count) > >> + if (!group_count || group_co

Re: [PATCH net 5/5] net: ipa: avoid going past end of resource group array

2020-10-28 Thread Alex Elder
On 10/27/20 7:14 PM, Willem de Bruijn wrote: On Tue, Oct 27, 2020 at 12:38 PM Alex Elder wrote: The minimum and maximum limits for resources assigned to a given resource group are programmed in pairs, with the limits for two groups set in a single register. If the number of supported resource

Re: [PATCH net 5/5] net: ipa: avoid going past end of resource group array

2020-10-28 Thread Alex Elder
On 10/27/20 7:14 PM, Willem de Bruijn wrote: > On Tue, Oct 27, 2020 at 12:38 PM Alex Elder wrote: >> >> The minimum and maximum limits for resources assigned to a given >> resource group are programmed in pairs, with the limits for two >> groups set in a single register. >> >> If the number of sup

Re: [PATCH net 5/5] net: ipa: avoid going past end of resource group array

2020-10-27 Thread Willem de Bruijn
On Tue, Oct 27, 2020 at 12:38 PM Alex Elder wrote: > > The minimum and maximum limits for resources assigned to a given > resource group are programmed in pairs, with the limits for two > groups set in a single register. > > If the number of supported resource groups is odd, only half of the > reg

[PATCH net 5/5] net: ipa: avoid going past end of resource group array

2020-10-27 Thread Alex Elder
The minimum and maximum limits for resources assigned to a given resource group are programmed in pairs, with the limits for two groups set in a single register. If the number of supported resource groups is odd, only half of the register that defines these limits is valid for the last group; that

[PATCH net 5/6] rxrpc: The server keyring isn't network-namespaced

2020-10-05 Thread David Howells
The keyring containing the server's tokens isn't network-namespaced, so it shouldn't be looked up with a network namespace. It is expected to be owned specifically by the server, so namespacing is unnecessary. Fixes: a58946c158a0 ("keys: Pass the network namespace into request_key mechanism") Si

[PATCH net 5/7] afs: Expose information from afs_vlserver through /proc for debugging

2020-08-27 Thread David Howells
Convert various bitfields in afs_vlserver::probe to a mask and then expose this and some other bits of information through /proc/net/afs//vlservers to make it easier to debug VL server communication issues. Signed-off-by: David Howells --- fs/afs/internal.h |9 + fs/afs/proc.c

[PATCH net 5/5] fsl/fman: fix eth hash table allocation

2020-07-30 Thread Florinel Iordache
Fix memory allocation for ethernet address hash table. The code was wrongly allocating an array for eth hash table which is incorrect because this is the main structure for eth hash table (struct eth_hash_t) that contains inside a number of elements. Fixes: 57ba4c9b ("fsl/fman: Add FMan MAC suppor

[PATCH net 5/5] net: hns3: fix for VLAN config when reset failed

2020-07-27 Thread Huazhong Tan
From: Guojia Liao When device is resetting or reset failed, firmware is unable to handle mailbox. VLAN should not be configured in this case. Fixes: fe4144d47eef ("net: hns3: sync VLAN filter entries when kill VLAN ID failed") Signed-off-by: Guojia Liao Signed-off-by: Huazhong Tan --- driver

[PATCH net 5/9] net: qed: fix excessive QM ILT lines consumption

2020-06-22 Thread Alexander Lobakin
This is likely a copy'n'paste mistake. The amount of ILT lines to reserve for a single VF was being multiplied by the total VFs count. This led to a huge redundancy in reservation and potential lines drainouts. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexander Lobakin Signed-off

Re: [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big

2020-06-11 Thread Alex Elder
On 6/10/20 6:36 PM, David Miller wrote: > From: Alex Elder > Date: Wed, 10 Jun 2020 14:53:32 -0500 > >> When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are >> enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes >> to 56 bytes currently). As a consequence the size of the

Re: [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big

2020-06-10 Thread David Miller
From: Alex Elder Date: Wed, 10 Jun 2020 14:53:32 -0500 > When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are > enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes > to 56 bytes currently). As a consequence the size of the gsi_trans > structure exceeds 128 bytes, and this

[PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big

2020-06-10 Thread Alex Elder
When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes to 56 bytes currently). As a consequence the size of the gsi_trans structure exceeds 128 bytes, and this triggers a BUILD_BUG_ON() error. These are useful configuration

[PATCH net 5/6] rxrpc: rxrpc_peer needs to hold a ref on the rxrpc_local record

2019-10-07 Thread David Howells
The rxrpc_peer record needs to hold a reference on the rxrpc_local record it points as the peer is used as a base to access information in the rxrpc_local record. This can cause problems in __rxrpc_put_peer(), where we need the network namespace pointer, and in rxrpc_send_keepalive(), where we nee

[PATCH net 5/8] net: stmmac: Correctly take timestamp for PTPv2

2019-09-27 Thread Jose Abreu
The case for PTPV2_EVENT requires event packets to be captured so add this setting to the list of enabled captures. Fixes: 891434b18ec0 ("stmmac: add IEEE PTPv1 and PTPv2 support.") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller"

[PATCH net 5/7] rxrpc: Add a private skb flag to indicate transmission-phase skbs

2019-08-29 Thread David Howells
Add a flag in the private data on an skbuff to indicate that this is a transmission-phase buffer rather than a receive-phase buffer. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |1 + net/rxrpc/sendmsg.c |3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH net 5/5] rxrpc: Use skb_unshare() rather than skb_cow_data()

2019-08-29 Thread David Howells
The in-place decryption routines in AF_RXRPC's rxkad security module currently call skb_cow_data() to make sure the data isn't shared and that the skb can be written over. This has a problem, however, as the softirq handler may be still holding a ref or the Rx ring may be holding multiple refs whe

[PATCH net 5/9] rxrpc: Abstract out rxtx ring cleanup

2019-08-22 Thread David Howells
Abstract out rxtx ring cleanup into its own function from its two callers. This makes it easier to apply the same changes to both. Signed-off-by: David Howells --- net/rxrpc/call_object.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/n

[PATCH net 5/5] rxrpc: Trace UDP transmission failure

2018-05-10 Thread David Howells
Add a tracepoint to log transmission failure from the UDP transport socket being used by AF_RXRPC. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 55 ++ net/rxrpc/conn_event.c | 11 ++-- net/rxrpc/local_event.c |3 +

[PATCH net 5/6] rxrpc: Fix resend event time calculation

2018-03-27 Thread David Howells
From: Marc Dionne Commit a158bdd3 ("rxrpc: Fix call timeouts") reworked the time calculation for the next resend event. For this calculation, "oldest" will be before "now", so ktime_sub(oldest, now) will yield a negative value. When passed to nsecs_to_jiffies which expects an unsigned value, th

Re: [PATCH net 5/5] net/ncsi: Fix length of GVI response packet

2017-10-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:09 +1100 > From: Gavin Shan > > The length of GVI (GetVersionInfo) response packet should be 40 instead > of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. > > # ethtool --ncsi eth0 swstats > : > RESPONSE OK

[PATCH net 5/5] net/ncsi: Fix length of GVI response packet

2017-10-18 Thread Samuel Mendoza-Jonas
From: Gavin Shan The length of GVI (GetVersionInfo) response packet should be 40 instead of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. # ethtool --ncsi eth0 swstats : RESPONSE OK TIMEOUT ERROR === GVI 0

[PATCH net 5/9] net: hns3: Fix for rx_priv_buf_alloc not setting rx shared buffer

2017-09-20 Thread Yunsheng Lin
rx_priv_buf_alloc is used to tell hardware how much buffer is used for rx direction, right now only the private buffer is assigned. For ae_dev that doesn't support DCB, private rx buffer is assigned to zero, only shared rx buffer is used. So not setting the shared rx buffer cause dropping of packet

[PATCH net 5/7] net: hns3: fixes the ether address copy with more appropriate API

2017-09-18 Thread Salil Mehta
This patch replaces the ethernet address copy instance with more appropriate ether_addr_copy() function. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns

Re: [PATCH net 5/7] gtp: Initialize 64-bit per-cpu stats correctly

2017-08-02 Thread Pablo Neira Ayuso
On Tue, Aug 01, 2017 at 12:11:10PM -0700, Florian Fainelli wrote: > On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a > lockdep splat indicating this seqcount is not correctly initialized, fix > that by using netdev_alloc_pcpu_stats() instead of an open coded > allocation. > >

[PATCH net 5/7] gtp: Initialize 64-bit per-cpu stats correctly

2017-08-01 Thread Florian Fainelli
On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a lockdep splat indicating this seqcount is not correctly initialized, fix that by using netdev_alloc_pcpu_stats() instead of an open coded allocation. Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling

[PATCH net 5/8] net: bcmgenet: synchronize irq0 status between the isr and task

2017-03-09 Thread Doug Berger
From: Doug Berger Add a spinlock to ensure that irq0_stat is not unintentionally altered as the result of preemption. Also removed unserviced irq0 interrupts and removed irq1_stat since there is no bottom half service for those interrupts. refs #SWLINUX-4311 Fixes: 1c1008c793fa ("net: bcmgenet

Re: [PATCH net 5/9] virtio-net: unbreak csumed packets for XDP_PASS

2016-12-23 Thread John Fastabend
On 16-12-23 06:37 AM, Jason Wang wrote: > We drop csumed packet when do XDP for packets. This breaks > XDP_PASS when GUEST_CSUM is supported. Fix this by allowing csum flag > to be set. With this patch, simple TCP works for XDP_PASS. > > Cc: John Fastabend > Signed-off-by: Jason Wang > --- > dr

[PATCH net 5/9] virtio-net: unbreak csumed packets for XDP_PASS

2016-12-23 Thread Jason Wang
We drop csumed packet when do XDP for packets. This breaks XDP_PASS when GUEST_CSUM is supported. Fix this by allowing csum flag to be set. With this patch, simple TCP works for XDP_PASS. Cc: John Fastabend Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 inser

Re: [PATCH net 5/7] net: ethernet: stmmac: dwmac-meson8b: fix probe error path

2016-11-30 Thread Kevin Hilman
Johan Hovold writes: > Make sure to disable clocks before returning on late probe errors. > > Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic > Meson 8b / GXBB DWMAC") > Signed-off-by: Johan Hovold Acked-by: Kevin Hilman

[PATCH net 5/7] net: ethernet: stmmac: dwmac-meson8b: fix probe error path

2016-11-30 Thread Johan Hovold
Make sure to disable clocks before returning on late probe errors. Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC") Signed-off-by: Johan Hovold --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 11 ++- 1 file changed, 10 insertions(+),

[PATCH net 5/7] net: ethernet: ti: cpsw: fix secondary-emac probe error path

2016-11-16 Thread Johan Hovold
Make sure to deregister the primary device in case the secondary emac fails to probe. kernel BUG at /home/johan/work/omicron/src/linux/net/core/dev.c:7743! ... [] (free_netdev) from [] (cpsw_probe+0x9cc/0xe50) [] (cpsw_probe) from [] (platform_drv_probe+0x5c/0xc0) Fixes: d9ba8f9e6298 ("driver: ne

[PATCH net 5/5] r8152: disable ALDPS and EEE before setting PHY

2016-09-20 Thread Hayes Wang
Disable ALDPS and EEE to avoid the possible failure when setting the PHY. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index e7a05dd..3c3cdb4 100644 --- a/dri

[PATCH net 5/6] rxrpc: Fix a use-after-push in data_ready handler

2016-08-09 Thread David Howells
Fix a use of a packet after it has been enqueued onto the packet processing queue in the data_ready handler. Once on a call's Rx queue, we mustn't touch it any more as it may be dequeued and freed by the call processor running on a work queue. Save the values we need before enqueuing. Without th

[PATCH net 5/7] net: hns: optimizate irq proccess for HNS V2

2016-03-24 Thread Yisen Zhuang
From: Sheng Li In hns V1, common_poll should check and clean fbd pkts, because it can not pend irq to clean them if there is no new pkt comes in. But hns V2 hw fixes this bug, and will pend irq itself to do this. So, for hns V2, we set ring_data->fini_process to NULL. Signed-off-by: Sheng Li Si

[PATCH net 5/6] net: hns: fixed service-ges setting MAC-addr bug

2016-03-03 Thread Daode Huang
From: Lisheng Service gmacs can not set mac add, this patch will fix the bug. Signed-off-by: Daode Huang Signed-off-by: Lisheng --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/

[PATCH net 5/6] net: hns: fixed service-ges setting MAC-addr bug

2016-03-03 Thread Daode Huang
From: Lisheng Service gmacs can not set mac add, this patch will fix the bug. Signed-off-by: Daode Huang Signed-off-by: Lisheng --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/

[PATCH net 5/5] dwc_eth_qos: do phy_start before resetting hardware

2016-02-29 Thread Lars Persson
This reverts the changed init order from commit 3647bc35bd42 ("dwc_eth_qos: Reset hardware before PHY start") and makes another fix for the race. It turned out that the reset state machine of the dwceqos hardware requires PHY clocks to be present in order to complete the reset cycle. To plug the

Re: [PATCH net 5/6] net: mvneta: The mvneta_percpu_elect function should be atomic

2016-02-01 Thread Gregory CLEMENT
Hi David, On sam., janv. 30 2016, David Miller wrote: > From: Gregory CLEMENT > Date: Fri, 29 Jan 2016 17:26:06 +0100 > >> @@ -370,6 +370,8 @@ struct mvneta_port { >> struct net_device *dev; >> struct notifier_block cpu_notifier; >> int rxq_def; >> +/* protect */ >> +s

Re: [PATCH net 5/6] net: mvneta: The mvneta_percpu_elect function should be atomic

2016-01-29 Thread David Miller
From: Gregory CLEMENT Date: Fri, 29 Jan 2016 17:26:06 +0100 > @@ -370,6 +370,8 @@ struct mvneta_port { > struct net_device *dev; > struct notifier_block cpu_notifier; > int rxq_def; > + /* protect */ > + spinlock_t lock; > > /* Core clock */ > struct clk *

[PATCH net 5/6] net: mvneta: The mvneta_percpu_elect function should be atomic

2016-01-29 Thread Gregory CLEMENT
Electing a CPU must be done in an atomic way: it should be done after or before the removal/insertion of a CPU and this function is not reentrant. During the loop of mvneta_percpu_elect we associates the queues to the CPUs, if there is a topology change during this loop, then the mapping between t

Re: [PATCH net 5/7] openvswitch: Reject ct_state unsupported bits

2015-09-30 Thread Pravin Shelar
On Wed, Sep 30, 2015 at 6:20 PM, Joe Stringer wrote: > On 30 September 2015 at 17:31, Pravin Shelar wrote: >> On Tue, Sep 29, 2015 at 3:39 PM, Joe Stringer wrote: >>> Previously, if userspace specified ct_state bits in the flow key which >>> are currently undefined (and therefore unsupported), t

Re: [PATCH net 5/7] openvswitch: Reject ct_state unsupported bits

2015-09-30 Thread Joe Stringer
On 30 September 2015 at 17:31, Pravin Shelar wrote: > On Tue, Sep 29, 2015 at 3:39 PM, Joe Stringer wrote: >> Previously, if userspace specified ct_state bits in the flow key which >> are currently undefined (and therefore unsupported), then they would be >> ignored. This could cause unexpected b

Re: [PATCH net 5/7] openvswitch: Reject ct_state unsupported bits

2015-09-30 Thread Pravin Shelar
On Tue, Sep 29, 2015 at 3:39 PM, Joe Stringer wrote: > Previously, if userspace specified ct_state bits in the flow key which > are currently undefined (and therefore unsupported), then they would be > ignored. This could cause unexpected behaviour in future if userspace is > extended to support a

[PATCH net 5/7] openvswitch: Reject ct_state unsupported bits

2015-09-29 Thread Joe Stringer
Previously, if userspace specified ct_state bits in the flow key which are currently undefined (and therefore unsupported), then they would be ignored. This could cause unexpected behaviour in future if userspace is extended to support additional bits but attempts to communicate with the current ve

[PATCH net 5/5] stmmac: Configure Flow Control to work correctly based on rxfifo size

2015-04-15 Thread Vince Bridgers
Configure flow control correctly, and based on the receive fifo size read as a property from the devicetree since the Synopsys stmmac fifo sizes are configurable based on a particular chip's implementation. This patch maintains the previous incorrect behavior unless the receive fifo size is found i

RE: [PATCH net 5/5] qlcnic: Implement ndo_gso_check()

2014-11-05 Thread Shahed Shaikh
NIC Dev; Tom Herbert (Partner - google); linux-kernel > Subject: [PATCH net 5/5] qlcnic: Implement ndo_gso_check() > > ndo_gso_check() was recently introduced to allow NICs to report the > offloading support that they have on a per-skb basis. Add an implementation > for this driver w

[PATCH net 5/5] qlcnic: Implement ndo_gso_check()

2014-11-04 Thread Joe Stringer
ndo_gso_check() was recently introduced to allow NICs to report the offloading support that they have on a per-skb basis. Add an implementation for this driver which checks for something that looks like VXLAN. Implementation shamelessly stolen from Tom Herbert: http://thread.gmane.org/gmane.linux.

[PATCH] net #5

2001-05-29 Thread Andrzej Krzysztofowicz
The following patch fixes some long udelay()s in aironet.c and saa9730.c in the current kernel tree. Andrzej *** PATCH 5 *** diff -uNr linux-2.4.5-ac4/drivers/net/aironet4500_card.c linux/drivers/net/aironet4500_card.c --- linux-2.4.5-ac4/dri