Re: [PATCH] net sched: text ematch: zero out ts_state before using it

2014-10-09 Thread Omar Sandoval
On Thu, Oct 09, 2014 at 02:48:54PM -0700, Cong Wang wrote: > On Thu, Oct 9, 2014 at 9:05 AM, Omar Sandoval wrote: > > textsearch_find zeroes out the offset, but the control buffer (which may or > > may > > not matter in this case) needs to be zeroed out as well. > > Why? skb_prepare_seq_read() i

Re: [PATCH] net sched: text ematch: zero out ts_state before using it

2014-10-09 Thread Cong Wang
On Thu, Oct 9, 2014 at 9:05 AM, Omar Sandoval wrote: > textsearch_find zeroes out the offset, but the control buffer (which may or > may > not matter in this case) needs to be zeroed out as well. Why? skb_prepare_seq_read() initializes the cb. Also, the comment says: * @state: uninitialized t

Re: [PATCH] net sched: text ematch: zero out ts_state before using it

2014-10-09 Thread Omar Sandoval
On Thu, Oct 09, 2014 at 09:05:21AM -0700, Omar Sandoval wrote: > textsearch_find zeroes out the offset, but the control buffer (which may or > may > not matter in this case) needs to be zeroed out as well. > > Signed-off-by: Omar Sandoval > --- > net/sched/em_text.c | 2 ++ > 1 file changed, 2

[PATCH] net sched: text ematch: zero out ts_state before using it

2014-10-09 Thread Omar Sandoval
textsearch_find zeroes out the offset, but the control buffer (which may or may not matter in this case) needs to be zeroed out as well. Signed-off-by: Omar Sandoval --- net/sched/em_text.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/sched/em_text.c b/net/sched/em_text.c index 15d3