Re: [PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-08 Thread Neil Horman
On Thu, Aug 08, 2013 at 09:14:31AM +0300, Dan Aloni wrote: > On Thu, Aug 8, 2013 at 8:50 AM, Neil Horman wrote: > > > > On Wed, Aug 07, 2013 at 12:02:44PM +0300, Dan Aloni wrote: > [..] > > > > > When my 'ifup eth' script was fired multiple times and ran concurrent o> > > > @@ -682,7 +689,11 @@ r

Re: [PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-07 Thread Dan Aloni
On Thu, Aug 8, 2013 at 8:50 AM, Neil Horman wrote: > > On Wed, Aug 07, 2013 at 12:02:44PM +0300, Dan Aloni wrote: [..] > > > When my 'ifup eth' script was fired multiple times and ran concurrent o> @@ > > -682,7 +689,11 @@ restart: > >* we might sleep in __netpoll_

Re: [PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-07 Thread Neil Horman
On Wed, Aug 07, 2013 at 12:02:44PM +0300, Dan Aloni wrote: > When my 'ifup eth' script was fired multiple times and ran concurrent on > my laptop, for some obscure /etc scripting reason, it was revealed > that the store_enabled() function in netconsole doesn't handle it nicely, > as recorded by the

[PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-07 Thread Dan Aloni
When my 'ifup eth' script was fired multiple times and ran concurrent on my laptop, for some obscure /etc scripting reason, it was revealed that the store_enabled() function in netconsole doesn't handle it nicely, as recorded by the Oops below (a syslog paste, but not mangled too much to prevent fr