Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

2014-09-13 Thread David Miller
From: Joe Perches Date: Sat, 13 Sep 2014 12:11:12 -0700 > On Sat, 2014-09-13 at 21:05 +0200, Heinrich Schuchardt wrote: >> Compiling with OCTEON_MGMT_ETHERNET gives a warning >> drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: >> warning: ISO C90 forbids mixed declarations and code >>

Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

2014-09-13 Thread Joe Perches
On Sat, 2014-09-13 at 21:05 +0200, Heinrich Schuchardt wrote: > Compiling with OCTEON_MGMT_ETHERNET gives a warning > drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] Maybe better to move the memset after the

[PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

2014-09-13 Thread Heinrich Schuchardt
Compiling with OCTEON_MGMT_ETHERNET gives a warning drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] The patch cleans up the code. Signed-off-by: Heinrich Schuchardt ---

[PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

2014-09-13 Thread Heinrich Schuchardt
Compiling with OCTEON_MGMT_ETHERNET gives a warning drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] The patch cleans up the code. Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de ---

Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

2014-09-13 Thread Joe Perches
On Sat, 2014-09-13 at 21:05 +0200, Heinrich Schuchardt wrote: Compiling with OCTEON_MGMT_ETHERNET gives a warning drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] Maybe better to move the memset after the

Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

2014-09-13 Thread David Miller
From: Joe Perches j...@perches.com Date: Sat, 13 Sep 2014 12:11:12 -0700 On Sat, 2014-09-13 at 21:05 +0200, Heinrich Schuchardt wrote: Compiling with OCTEON_MGMT_ETHERNET gives a warning drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code