Re: [PATCH] netdevsim: Fix error handling in nsim_fib_init and nsim_fib_exit

2019-10-13 Thread David Miller
From: YueHaibing Date: Fri, 11 Oct 2019 17:46:53 +0800 > In nsim_fib_init(), if register_fib_notifier failed, nsim_fib_net_ops > should be unregistered before return. > > In nsim_fib_exit(), unregister_fib_notifier should be called before > nsim_fib_net_ops be unregistered, otherwise may cause u

Re: [PATCH] netdevsim: Fix error handling in nsim_fib_init and nsim_fib_exit

2019-10-12 Thread Jakub Kicinski
On Fri, 11 Oct 2019 17:46:53 +0800, YueHaibing wrote: > In nsim_fib_init(), if register_fib_notifier failed, nsim_fib_net_ops > should be unregistered before return. > > In nsim_fib_exit(), unregister_fib_notifier should be called before > nsim_fib_net_ops be unregistered, otherwise may cause use-

[PATCH] netdevsim: Fix error handling in nsim_fib_init and nsim_fib_exit

2019-10-11 Thread YueHaibing
In nsim_fib_init(), if register_fib_notifier failed, nsim_fib_net_ops should be unregistered before return. In nsim_fib_exit(), unregister_fib_notifier should be called before nsim_fib_net_ops be unregistered, otherwise may cause use-after-free: BUG: KASAN: use-after-free in nsim_fib_event_nb+0x3